[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 2/5] xen/arm: Enable the existing x86 virtual PCI support for ARM
- To: Julien Grall <julien@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Fri, 15 Oct 2021 15:14:04 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Yf2VFPezLaqTJAgzasJxu6h/fBw8U0G5tjKhMyiq014=; b=E2Dsd5mufUXTaG7+SRbeh6yGuBU4Lf2R2Cyqc8/wSVe/dxe4E6VxBo+X4tUQFPmum4BQwHk+Zl2+vcqVzgUDWBDePjvQPRbeCUu+2NpHPazHqUb3nf9ECs8b/ypVdV01OWYcqyFhvvX1KXfZNBkzwT3Gt0jIWg0KoeZcBpZ27+VjHADwtSzB2FNLbQW2ZAFAoVIshCTmWts4AGRaQr9LxSI2sdSIHzLPtR122Nfg169naXucNGrFENNhQkEqiBDRk1bG3hbom6+FU9SO8Fwt4ieJ1/yMbgXW3BSlFs/UAJ+Pj/rowYLtsYP7jJff8lo31fNA73OnSIlHU2X+CVf87Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XrqS19EdtTFajPFsBLzFmeAZn5Dz1viBUA3nwDmpqD7UHaHAnFHoiBXS0d2xPa6co7J/VS+g3V79zg6t4DPtvhOoqxvvqjQl0Z0GXZMH1DMWoIkcq4gBFCdPariMTk4ElI+BK4Jaj7962vvgWEd/TI0tIxYa9I/9+i3MaqsXV3Zmgg/guMv/NCXaepaoROVvw7oz7MUssFYwT4n0vFZ/NnnCtR8t0gJn74Kjo44zyBX6dfZrAKe7k4kix26+xmXhiqHiTkEuG9HNR/1A8C9p4lpUswdpvOfAio/oWo3/7NR4/qD/Y+Gk5uVyZuodk52ejVpTOLDp8hLNmohcYpL19Q==
- Authentication-results-original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Rahul Singh <Rahul.Singh@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Paul Durrant <paul@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Fri, 15 Oct 2021 15:14:24 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHXwcz8unryLt1qUEeMdpd7xMjDNavUKeYAgAABFAA=
- Thread-topic: [PATCH v7 2/5] xen/arm: Enable the existing x86 virtual PCI support for ARM
Hi,
> On 15 Oct 2021, at 16:10, Julien Grall <julien@xxxxxxx> wrote:
>
> Hi Bertrand,
>
> On 15/10/2021 14:59, Bertrand Marquis wrote:
>> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
>> index 3aa8c3175f..082892c8a2 100644
>> --- a/xen/drivers/passthrough/pci.c
>> +++ b/xen/drivers/passthrough/pci.c
>> @@ -766,7 +766,21 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>> list_add(&pdev->domain_list, &hardware_domain->pdev_list);
>> }
>> else
>> + {
>> +#ifdef CONFIG_ARM
>> + /*
>> + * On ARM PCI devices discovery will be done by Dom0. Add vpci
>> handler
>> + * when Dom0 inform XEN to add the PCI devices in XEN.
>> + */
>> + ret = vpci_add_handlers(pdev);
>
> Sorry for only noticing it now. Looking at the last staging
> vpci_add_handlers() is annotated with __hwdom_init. On Arm, __hwdom_init
> means the function will disappear after boot.
>
> However, pci_add_device() can be called from a physdev op. So I think we
> would need to drop __hwdom_init. I can't seem to find this change in this
> series. Did I miss anything?
Good catch and not this is not in the serie.
Can we consider that a bug so that I can send a new patch or should I send a v8
?
Cheers
Bertrand
>
> The rest of the changes LGTM.
>
> Cheers,
>
> --
> Julien Grall
|
