[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 00/11] PCI: Drop duplicated tracking of a pci_dev's bound driver
- To: Bjorn Helgaas <helgaas@xxxxxxxxxx>
- From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
- Date: Fri, 15 Oct 2021 22:52:45 +0300
- Cc: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>, linux-pci <linux-pci@xxxxxxxxxxxxxxx>, Sascha Hauer <kernel@xxxxxxxxxxxxxx>, Alexander Duyck <alexanderduyck@xxxxxx>, Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>, Andrew Donnellan <ajd@xxxxxxxxxxxxx>, Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Fiona Trahe <fiona.trahe@xxxxxxxxx>, Frederic Barrat <fbarrat@xxxxxxxxxxxxx>, Giovanni Cabiddu <giovanni.cabiddu@xxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Ido Schimmel <idosch@xxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Jack Xu <jack.xu@xxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Jesse Brandeburg <jesse.brandeburg@xxxxxxxxx>, Jiri Olsa <jolsa@xxxxxxxxxx>, Jiri Pirko <jiri@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Marco Chiappero <marco.chiappero@xxxxxxxxx>, Mark Rutland <mark.rutland@xxxxxxx>, Mathias Nyman <mathias.nyman@xxxxxxxxx>, Michael Buesch <m@xxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Namhyung Kim <namhyung@xxxxxxxxxx>, "Oliver O'Halloran" <oohall@xxxxxxxxx>, Paul Mackerras <paulus@xxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Rafał Miłecki <zajec5@xxxxxxxxx>, Russell Currey <ruscur@xxxxxxxxxx>, Salil Mehta <salil.mehta@xxxxxxxxxx>, Sathya Prakash <sathya.prakash@xxxxxxxxxxxx>, Simon Horman <simon.horman@xxxxxxxxxxxx>, Sreekanth Reddy <sreekanth.reddy@xxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Suganath Prabu Subramani <suganath-prabu.subramani@xxxxxxxxxxxx>, Taras Chornyi <tchornyi@xxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Tomaszx Kowalik <tomaszx.kowalik@xxxxxxxxx>, Vadym Kochan <vkochan@xxxxxxxxxxx>, Wojciech Ziemba <wojciech.ziemba@xxxxxxxxx>, Yisen Zhuang <yisen.zhuang@xxxxxxxxxx>, Zhou Wang <wangzhou1@xxxxxxxxxxxxx>, linux-crypto <linux-crypto@xxxxxxxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, linux-perf-users@xxxxxxxxxxxxxxx, "open list:LINUX FOR POWERPC PA SEMI PWRFICIENT" <linuxppc-dev@xxxxxxxxxxxxxxxx>, linux-scsi <linux-scsi@xxxxxxxxxxxxxxx>, USB <linux-usb@xxxxxxxxxxxxxxx>, "open list:TI WILINK WIRELES..." <linux-wireless@xxxxxxxxxxxxxxx>, MPT-FusionLinux.pdl@xxxxxxxxxxxx, netdev <netdev@xxxxxxxxxxxxxxx>, oss-drivers@xxxxxxxxxxxx, qat-linux@xxxxxxxxx, "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 15 Oct 2021 16:53:37 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Fri, Oct 15, 2021 at 7:46 PM Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote:
> On Wed, Oct 13, 2021 at 04:23:09PM +0300, Andy Shevchenko wrote:
...
> so compared to Uwe's v6, I restored that section to the original code.
> My goal here was to make the patch as simple and easy to review as
> possible.
Thanks for elaboration. I have got it.
...
> You're right, this didn't make much sense in that patch. I moved the
> line join to the previous patch, which unindented this section and
> made space for this to fit on one line. Here's the revised commit:
>
>
> https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?id=34ab316d7287
Side remark: default without break or return is error prone (okay, to
some extent). Perhaps adding the return statement there will make
things robust and clean.
--
With Best Regards,
Andy Shevchenko
|
