[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI support for ARM
- To: Julien Grall <julien@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Fri, 15 Oct 2021 17:33:30 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NS8KAcOWF2xF+shDD8oVA0iXat1AOs8G2IynsaTEqM0=; b=PJXQBKv8Jy/VUkADUAMkYBjAwiW3KCtCCE8xVywuXVLxLg+nLoMo8XdxvRNwEbSQ33wor3vMzBIVjcojzwhJfr+DzjDaPUgHxjV1UvJ/OCuTx0XWdOE+q/6I+c4SV0C0eX+c7CMjpgMi2qywZzgy7X36XETcQwX/5kZTwPBcobgYswg1OIDYPQ9ppUgCf3CtKSGWYv6k4YcBqVSs5lgBgjH14XOCEgZp8ZHuIEPsRWFxUVEpu9zZxHYCv7ZtySkKZUvsSIZ7iryKoH52V/DUKG1/rcom0ki0fDTFmsgSWo6SL7ZkqhU+BFGPTOIaqjPhQC0Aqc/Q9dAzBGGp28NeXg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gL+HamsuZtbX9xkuTYEz4dEva8MGvYiMdMpJA3BvL5iDTnJamScoA4BSo0kqLEd+i4hV+B0z60zqlLSmVgWIt6OzPoyZ5p2vctSbJV7VlTCgUBJhuSUo6lOMowIfD/rTHGzeGUgUSMDLmrE03v02PSuzDU3i8a2zf/7mlQBNIy5PfClhsl6J6/xTJmMdv/JDrz9Y9QkoHRYQFyenGNCUNFldVapGFCechVrHCw0SCDlCCBW01RL/DVUIbUh3Zn7jSpJNiVzc80DXbObSC6RVvll0RGD1lQ1kMx+TUa1ciMTUWtIGyg789sh/Sb/065zBk4+EYv8az1/I1m806ZtNMQ==
- Authentication-results-original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "iwj@xxxxxxxxxxxxxx" <iwj@xxxxxxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, Rahul Singh <Rahul.Singh@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Paul Durrant <paul@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Fri, 15 Oct 2021 17:34:03 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHXweULx+Lzp09rU0elFmx0jxVt5qvUT3iAgAACRwA=
- Thread-topic: [PATCH v8 2/5] xen/arm: Enable the existing x86 virtual PCI support for ARM
Hi Julien,
> On 15 Oct 2021, at 18:25, Julien Grall <julien@xxxxxxx> wrote:
>
> Hi Bertrand,
>
> On 15/10/2021 17:51, Bertrand Marquis wrote:
>> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
>> index 3aa8c3175f..35e0190796 100644
>> --- a/xen/drivers/passthrough/pci.c
>> +++ b/xen/drivers/passthrough/pci.c
>> @@ -756,6 +756,19 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>> if ( !pdev->domain )
>> {
>> pdev->domain = hardware_domain;
>> +#ifdef CONFIG_ARM
>> + /*
>> + * On ARM PCI devices discovery will be done by Dom0. Add vpci
>> handler
>> + * when Dom0 inform XEN to add the PCI devices in XEN.
>> + */
>> + ret = vpci_add_handlers(pdev);
>
> I don't seem to find the code to remove __init_hwdom in this series. Are you
> intending to fix it separately?
Yes I think it is better to fix that in a new patch as it will require some
discussion as it will impact the x86 code if I just remove the flag now.
>
> With that addressed:
>
> Acked-by: Julien Grall <jgrall@xxxxxxxxxx>
>
Thanks
Bertrand
> Cheers,
>
>
> --
> Julien Grall
|
