[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] x86/HVM: correct cleanup after failed viridian_vcpu_init()


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 18 Oct 2021 08:43:46 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6RTaJnDpsf+3jxyWaCH4JPBdEEWZCkOkmhH6iZy3jXA=; b=PIvfPttuiC/JagytyKYJ0B+qSQ2SSvlxY9W62EamaP2R6kesYhJ2f+opRZyDucwSLsv1OrL+PXuLOynsHeDcbqUm/qt0XOc3wR4zabF+4O4dhjjcv64FY9EOJS2RxlOXN/x+iQSaRZk3tzIp5weUY0oBDYHKOamzQoKeDWa8liUuuooLsramKmmOnNvb77G1LhGD4TzGY1oo2WuEz+2EH70M25zStbxbl9j+q/RqKzoQ8EtNlJRjnvl5U/LE7tCzcZ2S26cIvtosiG52zySKN1LCXyUVpkyIdaDEGSAYZxpYP46o6ViwHHADwA1oj8fNB4YNe7IEHlqFStX63g4xUA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jQtCReAI+ENiYmID3+qHfozYnPfMAFcXTIRQ6/r3SGzSQMA4PBI8fEb8X8ZHwk5zGI2OSFCu0l8JsZDFjNBJK3DLFjIhOq0ym+LFunKIZb1gW6FBZSm+hm0lVqkqCsHrNzWfBPuEq6YYdZXU6hqU52F77GjjgVGVwE+3VWJRIHCjRkqt3xPyIADDKVoNriWxUTjROlw2jtJtGuGlOS7Uc99sOC89Ypa+sow0Nr/n+KQ8HFHX6JDDQ46+eAG7CKNC5IFUu4d0ng54PRJ3+y6F5YuEDKmzsyYfnSoPy+3D/rdSatTbUdHzw0Uh/vQkAiU2jrw4KFx+xJrQfMsm2j0AsQ==
  • Authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>
  • Delivery-date: Mon, 18 Oct 2021 06:44:01 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

This happens after nestedhvm_vcpu_initialise(), so its effects also need
to be undone.

Fixes: 40a4a9d72d16 ("viridian: add init hooks")
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -1583,7 +1583,7 @@ int hvm_vcpu_initialise(struct vcpu *v)
 
     rc = viridian_vcpu_init(v);
     if ( rc )
-        goto fail5;
+        goto fail6;
 
     rc = ioreq_server_add_vcpu_all(d, v);
     if ( rc != 0 )




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.