[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/shadow: make a local variable in sh_page_fault() HVM-only


  • To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Mon, 18 Oct 2021 08:21:04 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YAuQIayE3t3dABNES/1XDbBZ1R6MaeFa9BxG7v1wPGk=; b=FAaFG67AbCz3U7tjuxuQ1zpXS4PMWEWOiG/ORxZoHxUGcgyGD0sIYpPL1YUeWsTsVWo11XxLr92wZYCJSmhW3fhNqITm43s2ggcrcUgX1sqe4NkigHwdPBqoTNULfLUnqoaS642y4Hs2L4L7JEU4YHU3ls0k229kwmF/UUsCTw7tfnXRhccvcnsMOMBaE/bgxcPcpQ96GbnzOa6r7H4XiTyhVprnb6vJ5A743tRe+Idh7ukFZ1/LyKWr2G6zoR9KwKSCtGWImVkxtSGHt48Mb4Fgb/r53HVBMsYnk9HmueR0BzA9maCxM4nfa4UMv9G25pAw/2W+uX86CtBBoWsufg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nilTrGyfsCVkm0/Oyvdqq9FaFQA1apIwXT7KcETTRvoMnBnOCSAAULW8++TU8+OB5dxhGV6CJTeiez/ScRHK1mg0PZsDK/f1RUlOlaYJIQh7g0KUVyxdSvvIqfGksMqUDg7i2Vu1J9/zViSrNARhw4FQ0exo72k/HKiRyd+sb+dxWuWfYsr6k7SPBPgZzRk6mAwwQ8Y7h8d4TnSx5CXYMp6nOjzt56WDLmv3rBKubABsTSH+OVtJCLyG9QxGjRATiFioHS8r0EAPSuSQWY/Yh0vxho8Vky8FEYbF/LKLCgoAHtJXNPOybCQfNBaRx8vhVGpOH02NrDYk0yzMkztlNw==
  • Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>
  • Delivery-date: Mon, 18 Oct 2021 07:21:30 +0000
  • Ironport-data: A9a23:lZJ0Uq1JHzthnj1UQfbD5VJ2kn2cJEfYwER7XKvMYLTBsI5bp2MDx zAaXTvXP/iNZjOnc4wlbo+19RlX75CAztZrHVE/pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCan0ZqTNMEn970Es7wr5h2+aEvPDia++zk YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhpvFsl 8tSkqWJdAJ3MKTdsd06dQBYOnQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr 6VecW1TKEDY7w616OvTpu1Er8IvNsT0eqgYvWlt12rxBvc6W5HTBa7N4Le02R9t25wVTKuAP aL1bxJEQE7OW01uPm0mL5MVrr7yi0H6Uhth/Qf9Sa0fvDGIkV0ZPKLWGMrYfJmGSNtYmm6cp 3na5CLpDxcCLtudxDGZtHW2iYfnnyn2RYYTH72Q7eNxjRuYwWl7IAISfUu2p7++kEHWc85eL mQE9yxoqrI9nGSqUdvVTxC+uGSDvBMXR5xXCeJS1e2W4vOKuUDDXDFCF2MfLox93CMredA0/ maogoz3GhtWiYCQF3yU556tihWrOQFAeAfuehQ4ZQcC5tDipqQ6gRTOUstvHcaJszHlJd3j6 2vV9HZm1t3/meZOjv/hpQmW3FpAs7CQFlZtjjg7SF5J+e+QiGSNXIev9UTApchJKIKUXzFtV 1BVxpDAsoji4XyL/RFhodnh/pn0v55p0xWG2DaD+qXNERz3qhZPmqgLuFlDyL9BaJpsRNMQS Ba7VfltzJFSJmC2SqR8fpi8Dc8npYC5S4+5CqGJP4ASPsIgHONiwM2ITRTBt4wKuBN0+ZzTx L/BKZr8ZZrkIfUPIMWKqxc1juZwm3FWKZL7TpHn1RW3uYdyl1bOIYrpxGCmN7hjhIvd+V292 48Ga6OilkUOOMWjM3K/2dNCcjg3wY0TWMmeRzp/LbXYfGKL2QgJVpfs/F/WU9c5xvsIyrqRo yjVt40x4AOXuEAr4D6iMxhLQLjuQYx+vTQ8OyktNkyvwH8tfcCk66J3Snf9VeBPGDVLwaEmQ v8bVd+HB/gTGD3L9y5ENcv2rZB4dQTtjgWLZnL3bD86dp9mZgrI5t67IVe/qHhQVnK65Zkkv rmt9gLHWp5fFQ5sO9nbNaC0xFSrsHlDxO8rBxnUIsNecVnH+ZRxL3Cjlec+JswBcE2RxjaT2 wuMLw0foO3B/908/NXT3PjWpIa1CepuWEFdGjCDv7qxMCDb+EulwJNBD7nULWyMCjus9fz7N +tPzvz6PPkWp3pwstJxQ+Rx0KYzx9rzvLsGnA5qK2rGMgawAbR6L3jYgcQW7v9RxqVUsBedU 16U/oUIIq2APc7oHQJDJAchaejfh/gYliOLsKYwKUT+oiR24KCGQQNZOBzV0H5RK758MYUEx +Y9uZFJt1zj20RyatvW3DpJ82msL2AbV/R1v54XN4bnlw43xwwQepfbECL3vMmCZtgk3pPG+ dNIaH4uX4hh+3c=
  • Ironport-hdrordr: A9a23:ap/QvK2i/UP9gokSP67jHAqjBLYkLtp133Aq2lEZdPUzSL3+qy nOpoV+6faQsl0ssR4b9exoVJPufZq+z/5ICOsqU4tKNTOO0AHEEGgI1+rf6gylNyri9vNMkY dMGpIObeEY1GIK7voSNjPIceod/A==
  • Ironport-sdr: surCThefBP1a+6d97AieNTFaD+YFgYr7t4pzW82IWeSD8G609S9IL2DMNUDRPWa48o1rABwehC lOC7gZLAO0kkTVYF7uNulvsGs5pa1cpUGQiXtYDE6uUWClxLh138jPnzK/Pd5Me5pj9ikn2NlX aS3o84KM40lbYd1Z5jHyVU1MbOPvdo87CIBLwuraVtCrD03XgGx+x2B2QIV3fXe3X6rM3T5NXx lOmnSlP8RjROtHyE1IbgAlP8ALckGkYbKGGgSFKcijRx2ORXAztF/Dn8alkrylL6RubbpIFVFs 37bToz7ovHIWsP2nALt0mkno
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 18/10/2021 07:44, Jan Beulich wrote:
> I recall checking that "r" would still have a user, but when doing so I
> failed to recognize that all uses are inside a CONFIG_HVM conditional
> section.
>
> Fixes: 9f4f20b27b07 ("x86/shadow: adjust some shadow_set_l<N>e() callers")
> Reported-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.