[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Ping: [PATCH] x86/altp2m: don't consider "active" when enabling failed


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 18 Oct 2021 10:26:09 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WC8Hjl9zSOo/4nj9xF50M0CWijjrQvuXtd4yotDJfa0=; b=YN/3wSzVkfX7M76hMLI1AE6v1w6vqUL+bsSauhe0hossAZA4pnDSrXXDEm3hQYKtj3NcpmKo+f6kU+Gj6tIv0+fbx107AQ9i4dkc6PCxF0U4siw9nODN/GO02FFlKSp8yHEJZBkTax21FVAt5TMolHiUeZE4kFmEaeU87GHpKZ4sE88AFgBTcmxd195nED3bEdgQY1pp5DFc9wfJ+ya5j9RBhPJRjnBQRSYrvHUM6KySoNy0WmP3BJe0tDr/XpUEUe6qJdXBRxdv+ijOZzOT11YUQMw+4CzdHLgO3IMPw0ZsliDPAmTm+TNrLBSdm7YvOSGyI7XFd/t4z1Xct/AyUQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nx5c8dDe2nM9ey/E1a24QZjC7+/xz121bNJAqQbsFmQdGREDd6I35qPzpnXQDNAv3gCLoGCNS32QUvrN1mSePHV9psaK6sI3veRy8c0YiizWDjlVDrjGt3KC/DZHks8tdWSJrwwIhHOuIjYv+5nXjJE1iRhOS/2JRrAacVqmYm707/SihUvdDRmIHKNoiAXd/hWsE72HZD2xoUMvJmcG10Z2VYZ0PgeHPvhUkwbYQ92+cJABi6HpXUuBwoeZChFQoEce9Eg/NNEZ7kHr6VLhKWRkWSmaCQnLgObWYUVn7p36cQfyjaX7OVzJewx4sexrdxVabUXnDJN+cVwVWI8P7g==
  • Authentication-results: bitdefender.com; dkim=none (message not signed) header.d=none;bitdefender.com; dmarc=none action=none header.from=suse.com;
  • Cc: George Dunlap <george.dunlap@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Tamas K Lengyel <tamas@xxxxxxxxxxxxx>, Petre Pircalabu <ppircalabu@xxxxxxxxxxxxxxx>, Alexandru Isaila <aisaila@xxxxxxxxxxxxxxx>
  • Delivery-date: Mon, 18 Oct 2021 08:26:20 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 25.08.2021 11:31, Jan Beulich wrote:
> We should not rely on guests to not use altp2m after reporting failure
> of HVMOP_altp2m_set_domain_state to them. Set "active" back to false in
> this case.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Because of their relationship, I'm also Cc-ing the vm-event maintainers /
reviewers: Maybe one of you would care to review this one?

Jan

> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -4609,6 +4609,8 @@ static int do_altp2m_op(
>              if ( ostate )
>                  p2m_flush_altp2m(d);
>          }
> +        else if ( rc )
> +            d->arch.altp2m_active = false;
>  
>          domain_unpause_except_self(d);
>          break;
> 
> 




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.