[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 05/12] xen: don't include asm/hypercall.h from C sources
- To: Juergen Gross <jgross@xxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 18 Oct 2021 14:39:55 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ipJNu4qj6dm2jYX0skiI/XOERdPqIDqfgYF+nBOsLdY=; b=dwD/y7F0f5c+fiG2voKzkFst7ijmBrPQQas/adSKxMXdEU9NuKj2pbukrKTCd6INm/e4oBcWq8deUp0lKsdTMg8o444D5R9IH+Ap+Ps2WdrA75oXht1zUPg6Cp0rpXd/0Tr9FyAAyXjhIV0WNjEHPQ1BW5kIQan0BWRWVA/d8CureeiorampHj3oImpY9+WsoVIRcWa5xqna2VWoFxhiJrajzsyODTVT1oRyHe5/SwuiPzS/KiyH5jgWTh9N0oKHPk5ki9hYXHCUxBmg925I27q9y5rlzBs6FBLU6t2je6/dBlgTpV1+gQN5j4xl7+Tx88EUqBn+71Jn8gtgifsyXA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WDvmVzyhzpQXsdqgxbu1qYcp0Wh9312WfjE1rnxuVyLpwG0B9+TwGqU4lJCktP5RZUcmF167wPbIBzby6uX76Y2IOsbbXb5oIpsKrpsyF26cmlFcI7xsaiZ0zRV2+gDgIp/RlHDzqxfhQtZ9kl2AsTA0La5hypX5VCJVwZ8SXq8KGgkFiVO21ec6XTmQYbHf2OVvlnRhaQ6sq2mThV+A8uAkA+54bbSGR5yHwntLA8D4rNc7qg3te/Cczyrp2k0PlXC/tUbifFBA/An+Eg0ltVRPFmJPqQig4TL76p+50DZb4Bhu87U/+0xSAKBJns1APFIrjcGrTWvJoeOh7Z7iyw==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 18 Oct 2021 12:40:12 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 15.10.2021 14:51, Juergen Gross wrote:
> --- a/xen/arch/x86/x86_64/mm.c
> +++ b/xen/arch/x86/x86_64/mm.c
> @@ -32,7 +32,6 @@ EMIT_FILE;
> #include <asm/page.h>
> #include <asm/flushtlb.h>
> #include <asm/fixmap.h>
> -#include <asm/hypercall.h>
> #include <asm/msr.h>
> #include <asm/pv/domain.h>
> #include <asm/setup.h>
Afaict xen/hypercall.h also doesn't need including here. But I can
agree that this is at best a partly related change.
> --- a/xen/arch/x86/x86_64/platform_hypercall.c
> +++ b/xen/arch/x86/x86_64/platform_hypercall.c
> @@ -41,8 +41,8 @@ CHECK_pf_resource_entry;
> #undef xen_pf_resource_entry
>
> #define COMPAT
> -#define _XEN_GUEST_HANDLE(t) XEN_GUEST_HANDLE(t)
> -#define _XEN_GUEST_HANDLE_PARAM(t) XEN_GUEST_HANDLE_PARAM(t)
> +#undef guest_handle_okay
> +#define guest_handle_okay compat_handle_okay
Is this a change that slipped in here from patch 3, accompanying
-#define do_platform_op(x) compat_platform_op(_##x)
+#define do_platform_op(x) compat_platform_op(x)
there? Or does that change belong here? I have to admit anyway that
it's not entirely clear to me why this adjustment needs making.
> --- a/xen/common/compat/grant_table.c
> +++ b/xen/common/compat/grant_table.c
> @@ -4,6 +4,7 @@
> */
>
> #include <compat/grant_table.h>
> +#include <xen/hypercall.h>
Nit: Generally compat/*.h go last.
Jan
|
