[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/PoD: defer nested P2M flushes
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 19 Oct 2021 10:17:07 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cvibTTjJ/Ho86MIUJF0vJCTQshy/ICg8hJvurCqVAgY=; b=Y75UtwEL0MTcTbLs6iZgTH2iwa2JEMhlY59lnlARuj3PZPB4MZ76EFREvKvDRuWDIl/AuPo+xXWLIR/MadDq7dRqD0vUg8RCfIAxI35kuvEzpQBYUM80JUUKCZWJMDH6Bbrdk0ZvK79luF4SyIFblKaSqmASSYy/msb/AJTKMFF2IC5hL7JPIYLSbVtVd4cjBeme9YXd/gL68veT66Ay4HHLS8tkWnc3DbIPb1kb3jX74tZghNCJ/gO/9msywwJg7EdRFt2EY7vzCbsd5729WSfBW2OBosi0e+ZP/GIINTjLYLJhQJDpcFuE2Y+qMVq8DunOgpJ5X61CC56HuRmNYA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P15S3Zs8MNLeA2/lv7bfrvkFobMPQ5GNhBrpKDxXLv9WoYRpF1QDp8osnY5DZUe6p1fWNeCUriSPGrRetmdhKpQgd3Kw/u3C0GwECIbXWp16aaYfRaX6I5dm8fsrvIV3HtOXli6D13JaWUBm7Ns0IQX3vsSKCiDEhJKTKE974CON+3aem2qhqXcfUuKa1cYSINcNUGuy6tBxVatepmfJpTmFbIwJg4HyD1IjDRiMU78DHHOqkHoDUmlv6r4xAnVumjLpzD/7HlyBCyb2w7fYl9PaKgfVFGN3LjAtj7C+hp/QhJI48XfJvqy5EdJWmVUp2GsKv3LL7W2Hq67fGRklFw==
- Authentication-results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>
- Delivery-date: Tue, 19 Oct 2021 08:17:20 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19.10.2021 10:09, Roger Pau Monné wrote:
> On Mon, Oct 11, 2021 at 10:17:08AM +0200, Jan Beulich wrote:
>> @@ -1229,8 +1242,9 @@ p2m_pod_demand_populate(struct p2m_domai
>> __trace_var(TRC_MEM_POD_POPULATE, 0, sizeof(t), &t);
>> }
>>
>> - pod_unlock(p2m);
>> + pod_unlock_and_flush(p2m);
>> return true;
>> +
>> out_of_memory:
>> pod_unlock(p2m);
>
> Don't you need to set defer_nested_flush = false in the out_of_memory
> label? (as you don't call pod_unlock_and_flush that would do it)
Yes of course - thanks for spotting. I had pod_unlock_and_flush() here
too initially, and when switching back I forgot to convert rather than
just delete that.
Jan
|
