[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] xen/arm: call vpci_add_handlers on x86
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Tue, 19 Oct 2021 13:05:36 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a+DAAJ6yElLUOSAXT8J9gjdVlPvdfkobfHgCkZea4+Y=; b=PAyFaU8HzR8xvjN4S3bKhkHUFW+qZe93UwK3N5fQexvvEP/ajg1fIeI6wc5TD5JtBpecteUcn7Q9LkPiyMWswQOBBo/pVt6WFSS+BpzAttqWnES4bwA+TqjJQgw/byHrM4yQv1WTgunMRkPwBbJ6WioUprURq5daXRjetNjSOCHK0Sd4TZm5+7aveUDlgAcszXOYFao04OXCcFW87L3aSEymWqB5tOZkMYNYxMfvNIb9MijU5vjchwR4zkxamunXr4sdROyUBWPUAoGlhGEvTH2UH8XuOZwhW7NkmHww9q0dKCQ0qmUOBmQraDjGsKFJ4zblzrZ7ATxwEOyCS9N2aA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GZenecUtbVvSdJZ4RI1BJfSCuTGTLu+GvFMXdzt/+I2t8mvu88UdG3G9oHBYqYLFaiGp/Pds8xfFb05chVPjictrIZAEupF9j1mZtwHbY/BORcJ7yXcxLC7z42adyGPL/isM5lisYnVjOkrMc7I7ZIRu3Xn8CyPLo9S2+7gsUhVHQv5ubH6OURUaDzyIXH0cvsqBaIGjPEz+NoFpBSiNHd6TTLW1Rg+k99Ohs7/AfaCxyxfd1VUVN2ofBBCvQwHTTM0zVcmEaVd4IytfrRHPbFS8YU3k6w+NvDMJOTtLNe/S4VbTD1BjN1Fv8OVLXjGSYmYwxCr3u9SKo2wLM/KVdg==
- Authentication-results-original: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Cc: "iwj@xxxxxxxxxxxxxx" <iwj@xxxxxxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "Oleksandr_Andrushchenko@xxxxxxxx" <Oleksandr_Andrushchenko@xxxxxxxx>, Paul Durrant <paul@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 19 Oct 2021 13:05:57 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHXxNXoEqujjTQSU06NPtp38xWsdavaQCGAgAAKNYA=
- Thread-topic: [PATCH 1/3] xen/arm: call vpci_add_handlers on x86
Hi Jan,
> On 19 Oct 2021, at 13:29, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 19.10.2021 12:40, Bertrand Marquis wrote:
>> --- a/xen/drivers/passthrough/pci.c
>> +++ b/xen/drivers/passthrough/pci.c
>> @@ -756,11 +756,6 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>> if ( !pdev->domain )
>> {
>> pdev->domain = hardware_domain;
>> -#ifdef CONFIG_ARM
>> - /*
>> - * On ARM PCI devices discovery will be done by Dom0. Add vpci
>> handler
>> - * when Dom0 inform XEN to add the PCI devices in XEN.
>> - */
>> ret = vpci_add_handlers(pdev);
>
> I think it wouldn't hurt to retain a (re-worded) comment here, maybe
> along the lines of "For devices not discovered by Xen during boot,
> add vPCI handlers when Dom0 first informs Xen about such devices."
Ok, I will add that in v2.
Cheers
Bertrand
>
> Jan
>
|
