[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/3] Fixes: PCI devices passthrough on Arm
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Tue, 19 Oct 2021 13:11:03 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aRcSlt9I9aogKe+yx/QllPguBBDfVQPMojSfJPX5o/A=; b=j0HTqyR2+vHl7AF35FwZffLhL8exVrDehj7ZN0TqBnwwB6j/k8VXiII7rKm8Zb7qvd5SaHPzVkjYhHB+wzRfzi5xeyR0ZjR50NUnKpMUqS8Qt7Ir5okBdeujYlCrjIxm03oFrCedPRfC01IJGtNg1b//mcBf5CA7x5VYHPIAzHAC/eVVnAlKwdxBQaQHFNUxe3YABWkSyVJzsByHzRXWVgN3SWs/yXFA/+EFcUCES4uaSlolOya5P3pKsj/UwL4G9zweivpWGQel/3LPwRsUqJO//lrhJh9tSPUv3Nu7UDZ+6iC0ztB8hWMAFo4toJqNZvaTgiJtx8o+ofm/wLPdoA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WE9r7RqdcZoKYCZGTSgMnH4AKick3v2qtPJ5zmUNpSsoRhMfwd98L/1hc4YxVucySPRfMtQS8l0IzZ/pa6uOrtjnYV0nYeHlDFEayU6vmZANB5LolCjp6FAJcVBPsbK36whgjOAKI0GlIz8sfVh9IPkKQ2xpifBDfnMXplGkXWqRClvEcBRNeJjCE+FR4pNrc4x0XmbBQxYdfBdaPWkhFkY6uH52QL5hA7PuX39tqlLJryHwAtBqcAuK2Zd0gQMctMpejK7Co2Csfb/xUeeTMG1fAz9L1VsYwlM5SXpPILN/GNlnsnm91eeybsunCdFWNvbHufI+XwVwReNQIzlEmA==
- Authentication-results-original: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Cc: "iwj@xxxxxxxxxxxxxx" <iwj@xxxxxxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "Oleksandr_Andrushchenko@xxxxxxxx" <Oleksandr_Andrushchenko@xxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 19 Oct 2021 13:11:22 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHXxNXsWVtDOu3dTEyPepRQ+pXuJKvaP3CAgAAMbYA=
- Thread-topic: [PATCH 0/3] Fixes: PCI devices passthrough on Arm
> On 19 Oct 2021, at 13:26, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 19.10.2021 12:40, Bertrand Marquis wrote:
>> This patch serie is a follow-up after various findings on d59168dc05
>> ("xen/arm: Enable the existing x86 virtual PCI support for ARM") as of
>> agreed in [1].
>>
>> It does the following:
>> - enable vpci_add_handlers on x86 and not only on arm
>> - remove __hwdom_init flag for vpci_add_handlers
>> - add missing vpci handler cleanup in error path during pci_device_add
>> and pci_device_remove
>>
>> [1] https://marc.info/?l=xen-devel&m=163455502020100&w=2
>>
>> Bertrand Marquis (3):
>> xen/arm: call vpci_add_handlers on x86
>> xen/vpci: Remove __hwdom_init for vpci_add_handlers
>> xen/pci: Add missing vpci handler cleanup
>
> Imo all three changes need to be in a single patch.
I will merge all changes in one patch.
> An option might be
> to have first what is now patch 3, with CONFIG_ARM conditionals, which
> the subsequent patch would then delete. But what is now patch 1 cannot
> come before patch 2, and patch 2 alone would unduly impact x86 by
> moving code from .init.text to .text for no reason. (Still it could
> technically be done that way.)
>
> But let me also comment patches 1 and 2 individually (patch 3 looks
> okay, apart from the ordering issue).
Thanks
Bertrand
>
> Jan
|
