[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 06/12] xen: generate hypercall interface related code
- To: Juergen Gross <jgross@xxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 20 Oct 2021 09:11:45 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=i5ipr5uwL1Pptdu0/f+Uq9KEb990eKtnBM1P+A+UXq0=; b=cXI1Q01M/fHnVHgI/FJsd9P8DuxuPfeywTfnvM8qHo848mIY0tU5TfUw5CEDCZSvAl8ob36pp9x/QboJy5N7fWouaqnMiYE00trwHDoFCZVFXVoDfMW0CDlvUbqkckOwZTSMYGyb6IOkOl+5FnEu5psAvP2MYFw6RdrQRpI69TffkXps/wXyTW6iYDUpZInGcid5KAy/zwT4g+2lTr4TpYocZSureyzRujyCsbUulppWwJ378BdOXiyDBsMC0oIgtHsGaA5mM48DsqUmPV+zO3bMhQw5CNPElGbEjBl3wZTMn1a8KXU7LMjlQJSwurBlwCVs2QHSNTiFM35Y9uFUaw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QMjyUEKgVkbmj8GTGCJ7Ge3Oy4CJZMRuZRkl5mW8LHH8dGunT3qW3IFBZlHZksTmosSoJwUmfeFHsxmYWkfODpDUZV88BYNGnQ3RXHKBQkEGoWyTA1/Pi48nWMIDMwzSKQNXapsQo+aAb0ae0gj+j1l/fnDJc3atsS2MHX6jYz0a+TtcbQ9PjmAiiRCnWyYA5vhalNVyBfMXXBj15EPUuyGFqZFu97PiTa1lkKTicHzqTVf+Lqka9vwTNXZI6ye6FwxxBF1Dkdo7dJiVjpMy8RL9EzEgtjd2XOTtBULW8VAiQJlhec2EHpcQi6vlrr7HKMcVklY5ecrGnlQS+ssDHw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 20 Oct 2021 07:12:00 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 20.10.2021 09:02, Juergen Gross wrote:
> On 18.10.21 17:28, Juergen Gross wrote:
>> On 18.10.21 14:58, Jan Beulich wrote:
>>> On 15.10.2021 14:51, Juergen Gross wrote:
>>>> --- a/.gitignore
>>>> +++ b/.gitignore
>>>> @@ -332,10 +332,12 @@ xen/include/asm-x86/asm-macros.h
>>>> xen/include/compat/*
>>>> xen/include/config/
>>>> xen/include/generated/
>>>> +xen/include//hypercall-defs.i
>>>
>>> Nit: Stray double slash (unless this has a meaning I'm unaware of).
>>
>> Oh, right. No special meaning AFAIK.
>>
>>> Yet then I wonder: Shouldn't *.i be among the patterns at the top of
>>> the file, like *.o is?
>>
>> Yes, I can do that. Probably via a separate patch then.
>
> I can't do that, as we have one source file in our git tree matching
> this pattern: tools/libs/stat/bindings/swig/xenstat.i is used as an
> input file for swig for generating perl and python bindings. And the
> .i suffix seems to be the common one for swig input files.
Ugly. Since we have a rule to produce *.i in xen/Rules.mk, I think we
really should have these ignored. Perhaps a good enough reason to put
*.i in xen/.gitignore? And while at it perhaps also *.s? Unless
there's a way to specify a pattern for an entire subtree - it's not
clear to me whether xen/*.i in ./.gitignore would cover subdirs of
xen/ as well ...
Jan
|
