Re: [PATCH v2 1/1] xen/pci: Install vpci handlers on x86 and fix exit path

[Ian Jackson <iwj@xxxxxxxxxxxxxx>]

Bertrand Marquis writes ("Re: [PATCH v2 1/1] xen/pci: Install vpci handlers on 
x86 and fix exit path"):
> > On 20 Oct 2021, at 08:16, Jan Beulich <jbeulich@xxxxxxxx> wrote:
> > I'm inclined to suggest s/exit/error/ in the title though (and maybe
> > also s/path/paths/), which would be easy enough to do while committing.
> 
> @Ian: Please tell me if this is ok to be fixed during commit.

It's academic now, since you need a respin anyway, but I would in any
case have preferred a new version.  I find that a much better
workflow.  Expecting to make changes on commit pushes work onto
committers from submitters, which is less scaleable.

And it also ends up with committer making changes without any further
human review of any kind.  The committer must do so during an activity
which is otherwise often shallow and administrative.  This is not the
best way to get good results.

I believe I have made these points before, but perhaps not so clearly
and explicitly.  They are IMO very general.  (FTAOD I'm not saying
that making changes on commit is never appropriate, but it ought to be
exceptional.)

Thanks,
Ian.