[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/6] gnttab: allow setting max version per-domain


  • To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 20 Oct 2021 13:58:59 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6oe5YFwzDQBTv4wzm5wrQCTOqf6iST7DQnCBGT4XuHM=; b=Rr25lw58aliCWrbtUJZvYa4m7MRuPqiaVWZ2QMS3lnKdifwJd+iZoR5HZa2I33xxUKUjbei7o2saP1I5dVuH0hT3fhQ2tZwPwjl2bXlX5sn2qF2yT07Ahcvlk49cnHD4OU3Nzgz/lYS8FiSqnLyqA9BjIFThCIaBV3DjElJlDZTo7Gn5hlRWsAynBtPDwcLvdye1/495SdjbYOZE54eSHuXjw5ZH3W3dkHA887eargpREs/oTovapHuNdaeC1Uo6GwW4+MvBfwb1OB7FsWeTixqvytF1Kuz1mItcXBOKVtQ6zJatgbfE0XfdmOVcbY/R9lrlnM2etqFutcqvcqtOmQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aZrYCXklGM8ynuGUrO4LJxV4GxMPVVAe8wxZftN1B9kCU0TzHAuv1SV0e+5wLKYLQDidJo+9uu2NPFQwxLJxBHo3cvwZRCiYA0i46sKs4BnwvmRAZwJxQJJak+nWgzGvDRpWa/VE+J9eUjJ94h9O8s8J49MrFxPSMTwObgS4x6MR0n8DiQojXcpQKO/IqB0BOJqKJSv791GW0hd8+Eo/PMI8oyKWo0RNspMmWYqJ2RC7vj3bVSnJerCwaSFRX2CJVrjNmz9J2JTXZkQ811DMoiE8EsMpVi4C1eSbW/Xpj7ATEEI30w4ky4eh95uN4j0gGzfscnoyb4YEntQT2TotmA==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Christian Lindig <christian.lindig@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 20 Oct 2021 11:59:16 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 22.09.2021 10:21, Roger Pau Monne wrote:
> Introduce a new domain create field so that toolstack can specify the
> maximum grant table version usable by the domain. This is plumbed into
> xl and settable by the user as max_grant_version.
> 
> Previously this was only settable on a per host basis using the
> gnttab command line option.

One further remark: Already with the command line control is was
questionable in how far people are aware that PV guests may need to
use v2, if the host has memory beyond the 16Tb address boundary. I
wonder whether permitting to restrict to v1 on such hosts isn't
counterproductive. I guess at the very least a warning may want
logging.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.