[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 4/6] x86/HVM: also dump stacks from show_execution_state()
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Fri, 22 Oct 2021 12:30:46 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uoLmi8XjwYvIvNTlR2B7wn3vi07buVRKBWgAwmIbhNM=; b=nKchj5prBJ2W/gJRA2aYc1oSSK7uPav607h99tR/ohufGd+7MnqoA0CKfod7yehGutmTDpiRi8oOc988XsRkZb0OTEA1HpxDOpFGCBVdITCVDNg4I9jiUjpE0nfMwqQk8BQ2bW+wUPUWieEwT6EPJF0sMehN9CFyVNH4ZUKcE78a08J93gli2fHC8LYCh1VRzeN4zH5ZdyvnLjhvSDE0VwhkEv2kKz++KZ7jW6yVOvycooGY2XtZkcWO4KJp7dBYwVzugkMvI4BllIjmXvq6/bCapYHeQ0xAQwngG+hqvm93dLhMKA7w0wLmwtE7kov8wWXN+dEcb+IpuraVkcG3bQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GfwVvv0QDFLxpdU4xvE7CqRJBp5immZ8H4bTJ/RmATsg0tK0Hf4frww3jA+npoV8SDBY64fxDuAzacffw7HU5JNSTalHwGC3AsiNdI9K24lypagSEsGqhCxXg6ksv7IAA36qJ8rox7K/jC7NtZdz/Thh1XcLwBEfPWi1B+Ogi0mG5qoJRHcaWchp3TGucFGlkdAOR450EckNqW8h04kIPS5tYpMS/S+aJFpUu/TW6xC+WWAsadKOnXSCVZ/LcBIj0AOX7F5H/DvUoU2SM3V9Vwf7z3/PTgNqG+NeyiRR6a/J+V8I3ZlF7Uk7fJwA576zks3u9r23kqVYRtH1WFdJHQ==
- Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Fri, 22 Oct 2021 10:31:12 +0000
- Ironport-data: A9a23:iSRbCK0Nx+cUK0GudPbD5Qh2kn2cJEfYwER7XKvMYLTBsI5bp2RWx jdOW2/SaayNYTT2L9B+Yd+2o0tS6pWEy9VhHVc4pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCan8ZqTNMEn970Es7wbRh2OaEvPDia++zk YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhk8pb9 stS8qKMTig5E6zHyMIyYwcIOnQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr 6VecW1TKEDY7w616OvTpu1EnMMsIdOtJIoCknph0SvYHbAtRpWrr6DiuIAHh21q15km8fD2V e9GVANgaCn8TBRtMXs5A4pinuukiSyqG9FfgA3M/vdmi4TJ9yRu1JD9PdyTfcaFLe1Fk0Ddq m/Y8mDRBhABKMfZ2TeD6mirhOLEgWX8Qo16PL+y++NugVaT7ncOExBQXly+ycRVkWbnBYgZc RZNvHNz8+5iryRHU+URQTW0ulS6oAFbZeZXPP0X6Qrd7IXk/VawUz1soiF6VPQqs8o/RDoP3 1CPns/0CTEHjIB5WU5x5Z/P8mvsYXl9wXsqIHZeF1NcsoaLTJQb10qXFr5e/LiJYsoZ8N0a6 wuBqzQinP0thMoP2rTTEbvv0m/0+MahouLY4GzqsoOZAuFRONHNi2+AswGzARN8wGCxFAXpU J8swJD20Qz2JcvR/BFhuc1UdF1T296LMSfHnXlkFIQ7+jKm9haLJN4LvGEifRg5ap1ZKFcFh XM/XysLuPe/21PxNcdKj3+ZUZx2ncAM6/y1PhwrUja+SscoL1LWlM2fTUWRw3rsgCARfVIXY v+mnTKXJS9CU8xPlWPuL89EiOND7n1ulAv7GMGgpzz6gOX2WZJgYepcWLd4Rrtit/3sTcS82 4s3CvZmPD0GAbSgOHGOrNZPRb3IRFBiba3LRwVsXrfrCiJtGX07Cu+XxrUkeod/mL9SmPuO9 Xa4MnK0AnKl7ZEeAQnVOH1ldp31WpNz8SAyMSA2ZA760Hk/e4e/qqwYcsJvL7Ug8eViy99yT uUEJJrcUqgeFGyf9mRPd4T5oaxjaA+v2VCEMR26bWVtZJVnXQHIpIPpJ1O96CkUAyOrnsIiu Ln8hBjDSJ8OSl06XsbbYf6i1X2run0ZlL4gVkfEOIALKk7t7JJrO2r6ifpue5MALhDKxz270 QeKAEhH+bmR8tFtqNSQ3PKKtYakFed6D3F2JWiD4ObkLzTe80qi3ZREDLSCcwfCWT6m466lf +hUka3xaaVVgFZQvoNgOL931qZitcD3rrpXwwk4TnXGa1OnVuFpLnWchJQds6RMwvlSuBesW 1LJ8d5fYO3bNMTgGV8XBQwkcuXciq1ExmiMtaw4cBfg+St63LubSkEDbRCDhRtUIKZxLI54k /wqv9Qb6lDnhxcnWjpcYvu4K4hYwqQ8bpga
- Ironport-hdrordr: A9a23:+qvh+q4VnWVDlRtsnQPXwVuBI+orL9Y04lQ7vn2ZFiY6TiXIra +TdaoguSMc6AxwZJkh8erwXpVoZUmsiKKdhrNhQYtKPTOWwldASbsC0WKM+UyEJ8STzJ846U 4kSdkANDSSNykLsS+Z2njBLz9I+rDum8rE9ISurQYfcegpUdAa0+4QMHfrLqQcfng+OXNWLu v62iIRzADQB0j/I/7LSkUtbqzmnZnmhZjmaRkJC1oO7xSPtyqh7PrfHwKD1hkTfjtTyfN6mF K13TDR1+GGibWW2xXc32jc49B/n8bg8MJKAIiphtIOIjvhpw60bMBKWqGEvhoyvOazgWxa3+ XkklMFBYBe+nnRdma6rV/E3BTh6i8n7zvYxVqRkRLY0IfEbQN/L/AEqZNScxPf5UZllsp7yr h302WQsIcSJQ/cnQzmjuK4FC1Cpw6Rmz4PgOQTh3tQXc81c7lKt7ES+0tTDdMpAD/60oY6C+ NjZfuspMq+SWnqKkwxg1MfhOBFBh8Ib1C7qwk5y42oOgFt7TJEJxBy/r1Yop8CnKhNA6Wsqd 60a5iBOdl1P7grhJlGdZI8qP2MeyXwqCL3QRCvyGvcZdU60lL22tTKCeYOlayXkKJh9upFpH 2GaiIBiVIP
- Ironport-sdr: 45n/udTYUnJWbMQuCTT02mjIJyTEuS7WDx9VpVu+E0AaclpyHi7iRmcZMNW7RkjtBN74b9iAsh n7DEC359UIo2+qb70W+E977HjPPwcGmMddZQAPq/iCgtc4kPuclYqP+txHq+GaP7SpW19Ci1KY UlMcpF/Omddr+pv3mcudSOyH+jeN50JLDPXcQ14M3jLQe90zdSh1kLd4mvV+Xx7aHa7uyHXD59 pMzUVIYpYHzYM1EpzQ1FZVFPzN50HdMUX4nlChwbROGGMTIThViBHi2qZSrRCzZDDtS6wWTkum s10twhRyzkJKIGJJuWOASTZT
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Sep 29, 2021 at 03:14:46PM +0200, Jan Beulich wrote:
> Wire up show_hvm_stack() also on this path. Move the show_guest_stack()
> invocation out of show_stack(), rendering dead the is-HVM check there.
>
> While separating guest and host paths, also move the show_code()
> invocation - the function bails immediately when guest_mode() returns
> "true".
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> ---
> v4: New.
>
> --- a/xen/arch/x86/traps.c
> +++ b/xen/arch/x86/traps.c
> @@ -303,10 +303,6 @@ static void show_guest_stack(struct vcpu
> unsigned long mask = STACK_SIZE;
> void *stack_page = NULL;
>
> - /* Avoid HVM as we don't know what the stack looks like. */
> - if ( is_hvm_vcpu(v) )
> - return;
Might be good to keep it as an ASSERT_UNREACHABLE now.
Regardless:
Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Thanks, Roger.
|
