[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [REGRESSION] [PATCH 1/2] x86/hpet: Use another crystalball to evaluate HPET usability
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Mon, 25 Oct 2021 23:53:04 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V/nM33d6voo4983foIZGmSycJc72zb3kex2wyvJoWMY=; b=TcweYxmwqp0UD5nKIxg2utsq/jq/6TdPqKCgKhqCe3Z/D3OZKBsaIjIhyZ+oIaL9yaa8wx11H0wxxsGCiyQ7KpUAg8xbagbXUfqcV93siA/evLHRAtnc57YSvFBn1kilf6aohdDdrzj2/zwzuFyj/W9NAjbDp5jeUiWjJkw3fYjqxdkUsMYsdpyLsOSvgSdPIWmAF5iOZjl/KrVTLR+LyQ5rQdXlLJ1gUdjRRfuO/0oMJRvVK8KkfbH+O1f2ceD3Wq/m6HvcVLiJzD72ysQ86Rm/VgMiQSKT6iI51e6tPCqzeIpmHpGf+qzyMbv2uHCGLNL4eSQf8TLg4s1PjjgbWA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fdsUl+cwR9poEKUfJjIF1P2Rw11wB7i1Tegp+bL61T4GtUPa3ySfWF4I8AmKrXJHZBKPv37rEhgNDmEfvXmhaMfQrL8XWLyTGQ1WKf0zdixXpP9Hfy23FetCzSCFd/jZPkbSQVOtpSpBuPX1PdqTEMPQ7obM/a9Qg+Hwx01JdHUCLQdhORXHkUZvz9rIT1i96ABoCBuNPQU0MWfnJeJUmH7Kwfg/qaCQZphlY/gYQTD7eZn3aEmw6CCScznxr9v/lDHYWgylubsCn8Lj4KdnOi8XX7DLhp9YXoNrfgEoZ3cNGcg5eblPQ+0g9R52kFTT7VG2IWG1fdFYUeiCszqFyA==
- Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>
- Delivery-date: Mon, 25 Oct 2021 22:53:25 +0000
- Ironport-data: A9a23:Va1bhqL7QNNTgIA7FE+ROJIlxSXFcZb7ZxGr2PjKsXjdYENS12FUm GoaUWqAaKyKNmH9fNhzYdjip0MA7cTdxtM1GVFlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUZUideSc+EH140Eo5xrZj6mJVqYPR7z2l6 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB3ZlYF2y 4pWsqCwVCQGZJb2ouA0Dh1XRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr LpBdW5LPkvra+GemdpXTsFFgMg5IdatF4QYonx6lhnSDOo8QICFSKLPjTNd9Gpu3p0TQaeDD yYfQTpJaD/9QTMeAE8aFK5mhNas3zrPVjIN/Tp5ooJoujOOnWSdyoPFINfTP9CHW8hRtkKZv X7duXT0BAkAM96SwibD9Wij7sfNly7mXIMZFJWj6+VnxlaUwwQ7CQIUfUu2p+GjjUyzUM4ZL FYbkgIxqYAi+UrtScPyNyBUu1bd4ERaAYAJVbRntkfdkcI4/jp1GEBURG9Ga4M9s/M2WB8Fj GSzpdfAWDhg5ej9pW2myp+Yqja7OC4wJGAEZDMZQQZt3+QPsL3fnTqUEY49SP/dYsndXGiqm WjT/XdWa6A71JZTj82GEUb7byVAT3QjZjU+4RnLRSqb5wd9aZ/Ni2eAuAWDs6gowGp0SDC8U Jk4dyq2sL9m4XKlznXlrAAx8FaBvK7tDdEkqQQzd6TNDhz0k5JZQahe4StlOGBiOdsedDnib Sf74F0KucYDbCL7PP8mMupd7vjGKoC7TbzYug38NIISMvCdiifepEmCmnJ8L0iyyRNxwMnTy L+QcNq2DGZyNEiU5GHeegvp6pdynnpW7TqKHfjTlk37uZLDNC/9YepUazOmM7FmhJ5oVS2Iq r6zwePRkE4BOAA/CwGKmbMuwacidyhnWcmt8JwJLYZu4GNOQQkcNhMY+pt4E6RNlKVJjObYu Ha7X05T0l3kgnPbbw6NbxhehHnHBP6TdFo3Yn4hO0iGwX8mbdr95asTbcJvL7Im6PZi3bh/S PxcI5eMBfFGSzLm/TUBbMai8Nw+JUrz3Q/ebTC4ZDUffoJ7Q1Cb8NHTYQaypjIFCTC6tJVir uT4hB/bW5cKWy9rEN3SNKC011q0sHVEwLByUkLEL8N9YkLp9IQ2eSX9guVue5MHKAnZxyvc3 AGTWE9Kqe7Iqo4z0d/ImaHb8Nv5T7ogRhJXRjCJ46y3OC/W+nuY7bVBCOvYLyrAUG7U+bm5Y bkHxf/LL/Bazk1BtJBxEug3wPtmtcfvvbJT0i9tAG7PMwawErplL3SLgZtPu6lKyuMLsAe6Q BvSqNxTOLHPM8L5Cl8BYgEia73bh/0TnzDT69UzIVn7u3ArrObWDx0KMknekjFZIZt0LJghk LUot8Mh4gCijgYnb4SdhSdO+mXQdnENXs3LbH3B7FMHXubz9mx/XA==
- Ironport-hdrordr: A9a23:mhjzfqiYhHnWfDiIOB4z7izcEHBQX0p13DAbv31ZSRFFG/FwyP rAoB1L73PJYWgqNU3I+ergBEGBKUmskKKdkrNhQotKOzOWxFdATbsSkLcKpgePJ8SQzJ8k6U 4NSdkYNDS0NykBsS+Y2njJLz9D+qj/zEnAv463pB0MPGIaGJ2IrT0JbjpzencGNTWubqBJcq Z0iPA3xQZINU5nFfhSURI+Lpb+TpDw5d/bSC9DIyRixBiFjDuu5rK/Ox+E3i0GWzcK5bs562 DKnyHw+63m6piAu1Dh/l6Wy64TtMrqy9NFCsDJos8JKg/0ggLtQIh6QbWNsB08venqwlc3l9 vnpQsmIq1Imj/sV1DwhSGo9xjr0T4o5XOn4ViEgUH7qci8fz4+A9opv/MQTjLpr24b+P1s2q NC2GyU87BNCwnboSj779/UEzl3i0uduxMZ4K4upk0adbFbRK5arIQZ8k8QOowHBjjG5IcuF/ QrJN3A5cxRbUiRYxnizyhSKeSXLzYO9yq9Mw0/UpT/6UkToJk59TpX+CUnpAZCyHpnIKM0oN gtMcxT5fhzp4EtHORA7dw6ML6K41r2MGTx2VKpUCba/Z48SgbwQr7Mkf4IDbKRCdY1JKVbou W3bLofjx9qR37T
- Ironport-sdr: 8czdV+MxPXHOIBlpiQrHWdAjttpwzfrEX/P8i3lxLh1m9UxAte834VHnLtay7u3/mRYqQgNL+E sHOG/fOAqI/5wLAnvorzMywBfDveWhRmcghPmRFzebIrt3hIRtAoqc6BwM5Z5KLzC7Ot2Q24R/ 36y1nF6XWShIOCze6U3Oy2hTrPNJspvaZmcUOnVg7azUIq1E2CLwYDMJd7JqkyAHdxrPLBXZLm 81M0C7f6AbTEKMa06khPD90cs0TDo18+GTAN31JWWbUUk7RJS95OGkm5uoATp5Oj/IFtYmKPol OHMIQy00x7UAWqZkDMgRaf/u
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19/10/2021 08:07, Jan Beulich wrote:
> From: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>
> On recent Intel systems the HPET stops working when the system reaches PC10
> idle state.
>
> The approach of adding PCI ids to the early quirks to disable HPET on
> these systems is a whack a mole game which makes no sense.
>
> Check for PC10 instead and force disable HPET if supported. The check is
> overbroad as it does not take ACPI, mwait-idle enablement and command
> line parameters into account. That's fine as long as there is at least
> PMTIMER available to calibrate the TSC frequency. The decision can be
> overruled by adding "clocksource=hpet" on the Xen command line.
>
> Remove the related PCI quirks for affected Coffee Lake systems as they
> are not longer required. That should also cover all other systems, i.e.
> Ice Lake, Tiger Lake, and newer generations, which are most likely
> affected by this as well.
>
> Fixes: Yet another hardware trainwreck
> Reported-by: Jakub Kicinski <kuba@xxxxxxxxxx>
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> [Linux commit: 6e3cd95234dc1eda488f4f487c281bac8fef4d9b]
>
> I have to admit that the purpose of checking CPUID5_ECX_INTERRUPT_BREAK
> is unclear to me, but I didn't want to diverge in technical aspects from
> the Linux commit.
>
> In mwait_pc10_supported(), besides some cosmetic adjustments, avoid UB
> from shifting left a signed 4-bit constant by 28 bits.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
This breaks booting on recent Intel platforms.
Ian: Complete blocker for the release.
~Andrew
|
