[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: fix SBDF calculation for vPCI MMIO handlers
- To: Oleksandr Andrushchenko <andr2000@xxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Wed, 27 Oct 2021 10:59:36 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GyLAoVOwtWSbkeX/lFS/HhTqxZ8zHxWYYphy2V88xV8=; b=drTfHDhvk4Wk1VPxQZBtKw5/8W5Xp+pwD//aBb/Jvg/384iVqCQKKLCSA6ukxpOrmXjIj/3orTo5ekdrvLs4tlg15wDqadgp0/MUbqqSEnzA8xVIUCwT7kt4tQa7V8Z9JCW32adfhaoEOvTcm9lSIHYgnoUeglxn7T5R1MskL7OZmG9POem1z439tBqbku8LkXsUUV9zIJdilRJR7fud52KGPhdgh0cf6VS/e//df05ZK/8Uxr1yJn65RRYiQiH5lFJ0qKL6Lw7mWIkTudybxBk/4nGhypNwtoCpec3opD0YwLco3IJl/I1hJmSavc7MuupDGYZsHHY8ExR6j4/hSA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=abw4Rl+Lbp6wD1/s3+F6abC904DpeO6GqZJHT0rwdjPWsXnw7Qp/6Em2KSQYr8mhqwB3HOoYmPTgdS9JlWGYnmY7WZVojdV1aBG49PxOGh7gp1Z6hQkavrvsyP6vx1xygLKODhL35EvkcVI1eM2BDM4tc9cVgqgscxosGGTmbzUyfeGbghw6uJ7e3djzGatSm32CPO8AFPipei4pMMIXNXSp0OtWmVTltzQlFHbxYkYCupdQeecvDR9cS6oEQDJKLDCl6pJyOXx+oULTHEjhFNM2aBf+M5jnuUzs8cMrvhblojxMRFYrLRehkJW9YHNSpVrAUGO9PHuYxzLoqWHAGg==
- Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, <julien@xxxxxxx>, <sstabellini@xxxxxxxxxx>, <iwj@xxxxxxxxxxxxxx>, <bertrand.marquis@xxxxxxx>, <rahul.singh@xxxxxxx>, Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
- Delivery-date: Wed, 27 Oct 2021 09:00:04 +0000
- Ironport-data: A9a23:x1rPqqpQa2CF4WuQp4zPHRIOrvNeBmJ8YxIvgKrLsJaIsI4StFCzt garIBnSPazcZ2HyLo13b9639kIOvJTXz9FjTQdq/y4xRHgV9ZuZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dnd+4f5fs7Rh2Ncx2YLmW1rlV e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9 DlCnZaOVAsXIPfPotY6T0lAHQ5PLIpsyIaSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFJkYtXx6iynQEN4tQIzZQrWM7thdtNs1rp0QRqiGP 5tDAdZpRDXCajBJJm4VM5Zkg8X4uEmucDBZ73vA8MLb5ECMlVcsgdABKuH9cNGQWd9cmEreo 2vc5nn4GTkTLtnZwj2Amlqtme3njS79QJgVFrCz6rhtmlL77msXBR4NXF23u86wjEKkRslfI EwZ/CkphaUq/UntRd74NzWiqX6ZulgHWtxfE8Uz8gTLwa3Riy6JC25BQjNfZdgOsM4tWSdsx lKPh8nuBzFkrPuSU3313r6SoSnoYXBNBWAHbC4ACwAC5rHLu5ovhxjCStJiFq+djdDvHzz0h TeQo0AWhagXjMMN/7W2+xbAmT3Em3TSZldrvEONBDvjt14nIt7+D2C11bTFxfx+MYqnUAOCh kojh5iG4s8/HLanpBXYFY3hA4qVz/qCNTTdh3tmEJ8g6ymh9hafQGxA3N1tDBw2aphcKFcFd GeW4FkLvMYCYxNGeIcuO9rpY/nG25QMAjgMuhr8VdFJfoRqPDGO+CVjdCZ8NEi8zRByz8nT1 XqdGPtA7Er264w7k1JapM9HiNfHIxzSI0uJHfgXKDz8iNKjiIa9E+ttDbd3RrlRAFm4iAvU6 c1DEMCB1g9SVubzCgGOr9VOdw9RfSJjXMirwyCySgJlClA+cI3GI6SIqY7NhqQ/x/gF/gs21 ijlMqOn9LYPrSKecljbApySQLjuQYx+vRoG0d8EZj6VN4wYSd/3ts83LsJvFZF+rbAL5aMkH pEtJpTbatwSG2uvxtjoRcSkxGCUXE/w3lzm0uvMSGVXQqOMsCSTpYC9Llq1rXBfZsd13ONny 4CdOsrgacNrbyxpDdrMaeLpyFW0vHMHn/l1UVeOKd5WEHgAOqAwQ8AopvNoccwKNzvZwT6Wi 1SfDRsC/LGfqI4p6tjZw6uDqt7xQed5G0NbGUjd7Kq3anaGrjbyn9cYXbbaZy3ZWUP15L6mO bdfwcbjPaBVh11NqYd9TepmlPps+9v1qrZG5Q14B3GXPU+zA7ZtLyDej8lCv6FA3JFDvg6yV h7d89VWI+zRasjkDEQQNEwuaeHajaMYnTzb7PIUJkTm5XAooOrbABsKZxTV0X5TNrp4No8h0 NwNgs9O5lztkAcuP/aHkjtQqzaGIEsfXvh1rZodGoLq1FYmkwkQfZzGBybqy5iTcNEQYFIyK zqZiaee1bRRwk3OLyg6GXTXhLcPgJ0PvFZBzUMYJkTPkd3A36dl0BpU+DUxbwJU0hQYjL4jZ jk1bxV4dfeU4jNlpMlfRGT9SQhOCSqQ9lH111ZUxnbSSFOlVzCVIWAwUQpXEJv1L46IkuBnw Yyl
- Ironport-hdrordr: A9a23:vc77aa0U2Sxn9RAXhsiRiwqjBVRyeYIsimQD101hICG9Lfb3qy n+ppsmPEHP5Ar5OEtBpTiBUJPwJ0800aQFnLX5XI3SJjUO3VHIEGgM1/qG/9SNIVybygcZ79 YdT0EcMqyAMbEZt7eD3ODQKb9Jq7PrgcPY55av854ud3AQV0gJ1XYGNu/xKDwOeOApP+tfKH LKjfA32AZINE5nJPiTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1SvV Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfpWoCoZ 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8DLeiP28YAh/J9tKhIpffBecwVEnpstA3K VC2H/cn4ZLDDvb9R6NpuTgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed MeQv003MwmMm9yUkqp/FWGmLeXLzEO91a9Mwc/U/WuonhrdCsT9Tpd+CQd9k1wgq7VBaM0oN gsCZ4Y5o2mePVmGp6VNN1xMvdfNVa9NC4kEFjiaWgPR5t3cE4klfbMkcEIDaeRCdo18Kc=
- Ironport-sdr: +weyhMNiRvdofmfxxBNgLI+0YDLjWy20B8eA3nI5XF7ZbYtRKwIi3gy6mjeGtfpimoDdnQZq0H F8q+m/mIbDfnnOtTrsfjwzlFSww/d+cuuhNEuzn2GDEd5xkrWf9CRSPhw2qcPWiSFD9Vf5Ivdk pntNmBibYvEAXqkk49XWJhQLhUvS9W5tBKN0TSuUtbJzXkFc4xBZHAiWgLL1ct/dAIZTQigbYq rEBEefc4NygalsqXYAQ+yKFk3JC1LOAHifbuiayW5Hntbgox4h7TSPNT/JEpYf3jZH/h8JMh9L eL2joUrwZLJ/EPum+oAGv6mF
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Oct 27, 2021 at 11:25:33AM +0300, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
>
> While in vPCI MMIO trap handlers for the guest PCI host bridge it is not
> enough for SBDF translation to simply call VPCI_ECAM_BDF(info->gpa) as
> the base address may not be aligned in the way that the translation
> always work.
I think I've already raised this during review [0]. But this is only a
problem if you change the current value of GUEST_VPCI_ECAM_BASE
AFAICT, as the current value has bits [0,27] clear.
I assume this is a problem for the hardware domain that needs to trap
random base addresses as present on hardware, but that code hasn't
been committed yet.
If that's indeed the case, please expand the commit message to contain
this information.
Thanks, Roger.
[0]
https://lore.kernel.org/xen-devel/YWlnc3b0sj4akUWa@MacBook-Air-de-Roger.local/
|
