Re: [PATCH v2 3/3] automation: add a QEMU based x86_64 Dom0/DomU test

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Wed, 27 Oct 2021, Anthony PERARD wrote:
> On Mon, Oct 25, 2021 at 06:42:00PM -0700, Stefano Stabellini wrote:
> > From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
> > 
> > Introduce a test based on QEMU to run Xen, Dom0 and start a DomU.
> > This is similar to the existing qemu-alpine-arm64.sh script and test.
> > The only differences are:
> > - use Debian's qemu-system-x86_64 (on ARM we build our own)
> > - use ipxe instead of u-boot and ImageBuilder
> > 
> > Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
> > ---
> >  automation/gitlab-ci/test.yaml           | 24 ++++++
> >  automation/scripts/qemu-alpine-x86_64.sh | 95 ++++++++++++++++++++++++
> >  2 files changed, 119 insertions(+)
> >  create mode 100755 automation/scripts/qemu-alpine-x86_64.sh
> > 
> > diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml
> > index 91a10febbf..43d248a604 100644
> > --- a/automation/gitlab-ci/test.yaml
> > +++ b/automation/gitlab-ci/test.yaml
> > @@ -47,6 +47,30 @@ qemu-alpine-arm64-gcc:
> >      - /^coverity-tested\/.*/
> >      - /^stable-.*/
> >  
> > +qemu-alpine-x86_64-gcc:
> > +  stage: test
> > +  image: registry.gitlab.com/xen-project/xen/${CONTAINER}
> > +  variables:
> > +    CONTAINER: debian:stretch
> > +  script:
> > +    - ./automation/scripts/qemu-alpine-x86_64.sh 2>&1 | tee 
> > qemu-smoke-arm64.log
> 
> Maybe the log file should be called "qemu-smoke-x86_64.log" ? Or just
> "qemu-smoke.log"?

Good catch! This could be fixed on commit.

 
> I'm still not happy about the `apt install` in the middle of the test,
> but I guess that will do for now:
> 
> Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Thanks!

Now the series is fully acked and Ian gave his reviewed-by. If people
are OK with that I could commit it in a couple of days (and by the end
of this week).