[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 07/10] libxl: Only map legacy PCI IRQs if they are supported
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
- Date: Tue, 2 Nov 2021 11:37:21 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Yfo3T76HMGwsUVYuWcZgKdzS1lHT1OVl8si1cxNKG0A=; b=cJifyOBzu21nXX2IgSW7PP7eRp1iwH7B8A9PnbbDBuUbrsQZ1OFFhUcV0ku0Tv6ACvg6w+KEvHCyk3qT1kYnyDGX3JMDwJ0xJH5+n/6sjKO47oLWjop8xCshmdwbL4Oa3Cqc8ikEdw5vk3v3qhefC4cHMoz2upxIMqrabSFvhvZ7N01eU4XsNXrqHUeZqL7JLsOz8MfVpkNkByMHexqkCwI+1wjpptgT1wMx8necHFPXAjG5QKFvtBPvsXQszyH4rmR7+YxMxYAGVKvIGciONmUnXX3zynpYM1VVH1p6cgrSK6djubXhiheqCSIcRDcp2ar47r7smZk7B+rk9odgEA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iCskQVbj7ExoHIufn3KdIBM1hGCar87lQLOHL0GevPv/JQXdaiIZtkHP/P10bqCKVcO5QfzUfiVP/ScnKHeMuaWho3zjm9SW4gifCSxOJDRz0qLdR0r8K4hjGhNUHOI7u3KC/acp8CPkQ65RnEuiRWNub+KGwuBUxdxK+H52UWkpreJlpn+Ow91HApQExDY9RUDRkNv+aYn6YxucqWt2KQdmt9caqEmQW34OT2zxV0U6Z8r3CWLNijtgte58Csb7o/JkDUMF9bNG0xaBFBFCou0gNmEXUqaaQzQIcsRgVW1XZFqz/OAvLONnvcOTUPGvyieZ4resauIHt4IfoIw3XA==
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Artem Mygaiev <Artem_Mygaiev@xxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, "george.dunlap@xxxxxxxxxx" <george.dunlap@xxxxxxxxxx>, "paul@xxxxxxx" <paul@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
- Delivery-date: Tue, 02 Nov 2021 11:37:34 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHXvAknuuGQJumtOE+ut83tChlOwKvjzqeAgAAEa4CADG+EAIAAAVUA
- Thread-topic: [PATCH v5 07/10] libxl: Only map legacy PCI IRQs if they are supported
On 02.11.21 13:32, Jan Beulich wrote:
> On 25.10.2021 15:38, Oleksandr Andrushchenko wrote:
>> On 25.10.21 16:22, Roger Pau Monné wrote:
>>> On Fri, Oct 08, 2021 at 08:55:32AM +0300, Oleksandr Andrushchenko wrote:
>>>> --- a/tools/libs/light/libxl_pci.c
>>>> +++ b/tools/libs/light/libxl_pci.c
>>>> @@ -1364,6 +1364,15 @@ static void pci_add_timeout(libxl__egc *egc,
>>>> libxl__ev_time *ev,
>>>> pci_add_dm_done(egc, pas, rc);
>>>> }
>>>>
>>>> +static bool pci_supp_legacy_irq(void)
>>> A naming more inline with the PCI specification (since we insisted on
>>> using ECAM instead of MCFG) would be intx, ie: pci_supports_intx.
>> This will require a follow up patch if we all agree this change is needed.
>> @Jan, are you ok with the rename?
> Sure, but my view doesn't matter all this much anyway for libxl code.
Do you want a follow-up patch for this as the original change has been merged?
>
> Jan
>
Thanks,
Oleksandr
|
