[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/1] xen: update system time immediately when VCPUOP_register_vcpu_info
- To: Dongli Zhang <dongli.zhang@xxxxxxxxxx>, iwj@xxxxxxxxxxxxxx
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 2 Nov 2021 13:23:00 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ADSqHOqPM78e8QSmzMVdosD/25dj1ceueoTZXVCnNz4=; b=OThu4IThUULmuZvT7wjE3b7tSJvlCAjo/r1NS4Z6pRksgo+IjWTxPVeTbSepCPBmTN2+SS3kAW45yMf1Egrl7weug/kYCpRlkVJh7h/qp3fHW41uDNlIwe9NnaZxtNJ3gVIMXHw6ujomUWAMMWFWUdG/n9vjuB502M89h251LVSXF/RRt1FUtvghbQQoSyhqv1lqU8nP7kQSiP8xdefzMElFPoeE2q00KiJqh8QeD59p0zGii/SUZmWJjuIpOfM806GqzekCh4C1q6sqPFyMLwJGNy5sFKb0+RKvZYOkLbdypi6/f2QWyy/5ZILquU2DDF1eUxOdc0pO9NSb3FOqaQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mKV1oUPsFJ6/LIlZ0NO51vouwQHFLY78Bvq8QBUEVlhTJuiW8ExBYm8+pkbqwGvWNYnkg546RNUz/PJQfAXiFc/CcNjBvfCd3wABF88qR7PStO83CTuC7F0qyob8UoQhVIqZKuUqaOKXyeKvs0bRE0eFu7xu6/9S2NUeCBwnien0RQPUTBXbkOc1TCsLIACvC9aPRd6SuQ0b3l9rIDzU24hMwFNf3vNfZoscYeKAk+IY1twaKcfY3eYc0Svm1s8lYx0lbnkb2NPAKFRcfJkZMMhUfdyVrG4ysq7xYtvHUlytBuD6Bp+4phVdCyubAGIz/GsgF47An1n4Whv58Kj4Xw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: sstabellini@xxxxxxxxxx, julien@xxxxxxx, Volodymyr_Babchuk@xxxxxxxx, andrew.cooper3@xxxxxxxxxx, george.dunlap@xxxxxxxxxx, wl@xxxxxxx, joe.jin@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 02 Nov 2021 12:23:19 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 25.10.2021 19:35, Dongli Zhang wrote:
> The guest may access the pv vcpu_time_info immediately after
> VCPUOP_register_vcpu_info. This is to borrow the idea of
> VCPUOP_register_vcpu_time_memory_area, where the
> force_update_vcpu_system_time() is called immediately when the new memory
> area is registered.
>
> Otherwise, we may observe clock drift at the VM side if the VM accesses
> the clocksource immediately after VCPUOP_register_vcpu_info().
>
> Reference:
> https://lists.xenproject.org/archives/html/xen-devel/2021-10/msg00571.html
> Cc: Joe Jin <joe.jin@xxxxxxxxxx>
> Signed-off-by: Dongli Zhang <dongli.zhang@xxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Ian - any thoughts towards 4.16 here either way?
Jan
|