[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/traps: Fix typo in do_entry_CP()


  • To: Jan Beulich <jbeulich@xxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Wed, 3 Nov 2021 12:56:59 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4WoxbEitlizOc+uNhuQlrfGu8piRhbo4zk8G3aoBw9w=; b=RLZVnfb5E7+XYSjnQhG5Bl0Yv47aY3lFjranhUIjElOlcLtUdRZuJfZ+dgNoKgnWoxCHVvvbHYTBtoaqca5ALrjeaL/GJOyfyjHLwIZfFydk6VEY/f1lzcmfSofs1lk4BVL+TXsKuyYCCLqBCAIfn0AcX+E/AoLIMCxNZKagz3fIxT61y3ENknpvx1PHLo0HX0tQOUkzngtlfS0wZVCdytWZlefJNYOSrbibY/ADicFsPO9vsfGk2rt/HOSu4v5kuSBmS+Hy8++QN1+8LrXRwG5RfIbhclk5pnI2D+NZw4Pq/Qsd7ZToRSfjR1EWzN2pBWLzRbrJt8b6wK5NrTwIIg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NDmWvCZSV4j8xtLDGpvjYEt1ARbqc2F4gr60dhhTaFrdNdOknYJPPk4d0lWUAGQZ2aIczwC/WvvDOZ1vFPAIlx+2xwftYxtbjN5X9wxV60afkEkscuyNYRZvcSQeO4XccTsNjHOFLeZmr8+m+WTBAS5tOi+thoXYnLkATFzHJK21Qpb5ZIi9W1ALAKwGE582jOI3da3SUOYPNRooTmXCzQBJNhRo5bvTbTh4OrxEKhjHKE/QwLCgXHqhBCznSQdFMeRAgyjAjbGxO5ojXDPVvhDPaAb9hmomUkGBWOxSqUAg5tP7DbynTlWb6Mpoui6E3Ms9J1nfceu5NO5QITe+AQ==
  • Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Bobby Eshleman <bobby.eshleman@xxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Wed, 03 Nov 2021 12:57:24 +0000
  • Ironport-data: A9a23:OzUGX6s7MTDGaQpKA3nIDAdPT+fnVNxZMUV32f8akzHdYApBsoF/q tZmKW7SbPaDZWvzKd4latnl8hxVup6GyNYxTwQ5/Cs0Qi1D+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHhJZS5LwbZj29cx2YPhWWthh PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ NpltJeaczwCb6D3hN8NVDJ8EyF5J7UaweqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DFYUToHx/ixreCu4rW8vrSKTW/95Imjw3g6iiGN6DN 5tAMGYwMnwsZTVzYVEPDp4R392GoUmibxt7rA+XrvoOtj27IAtZj+G2bYu9lsaxbcRKnG6Iq 2Te5WP7DxoGctuFxlKt8Hihm+vOliPTQ58JGfuz8fsCqEKX7nweDlsRT1TTiem0jAuyVsxSL 2QQ+zEytu4i+UqzVN7/Uhak5nmesXY0Ud1aGfx85RqNzqfR6gCxCW0NTzoHY9sj3PLaXhRzi AXPxYmwQ2Uy7vvFEhpx64t4sxuzMgIvFkRTaBQYdhsCyP3joIYplk72G4ML/LGOsvX5HjT5w javpSc4hqkOgcNj65hX7WwrkBr3+MGXE1ddChH/Gzv8s1gnPNLNi5mAsACDtZ59wJClok5tV ZTus+yX96gwAJ6Ej0Rhq81dTejyt55p3NAx6GOD/qXNFRzxpBZPnqgKuVmSwXuF1O5eJ1cFh 2eJ6GtsCGd7ZifCUEOOS9vZ5z4W5abhD8/5cfvfc8BDZJN8HCfeonozNRHAgTi3zBhz+U3aB Xt9WZzyZZr9If8/pAdaus9HieN7rszA7TqLLXwE8/hX+eXHPyPEIVv0GFCPcvo4/Mu5TPb9q L5i2z+x40wHCoXWO3CPmaZKdAxiBSVrVPje9p0MHsbec1UOJY3UI6KIqV/XU9c+xPo9eyah1 izVZ3K0P3Kk2SaccVXWMSs+AF4tNL4mxU8G0eUXFQ/A81AoYJq17bdZcJ0yfLI98/dkw+IyR P4AE/hsyNwWFVwrIhwRMsvwqpJMbhOuiV7cNiapemFnLZVhWxbI6pnveQ62rHsCCS++tM0fp by811yEHcpfFlo6VMuGOuiyy16RvGQGnL4gVUX/PdQOKl7n95JnKnKtg6Zvcd0MMxjK2hCTy x2SXUUDveDIroJsqIvJiKmIop2HCex7GkYGTWDX4azvbXvR/3a5wJ8GW+GNJGiPWGTx8aSkR ONU0/Cjb6FXwAcU69JxSu85w7g/6t3jo65h4j5lRHibPU62Dr5AI2Wd2ZUdvKN62bIE6xC9X ViC+4cGNOzRat/lClMYOCEscv+HiaMPgjDX4Pk4fBf66Stw8ObVWEleJUDR2ilULb8zO4I52 +Yx/sUR7lXn2BYtN9+HiAFS9niNcSNcA/l26MlCDd+5kBcvx3FDfYfYW33/75y4YtlRNlUnf 22Pj63YirUAnkfPfhLfz5QWMTaxUXjWhC138Q==
  • Ironport-hdrordr: A9a23:/KT4+akb7DdB3YkRXAe1OcsMnD3pDfO8imdD5ihNYBxZY6Wkfp +V88jzhCWZtN9OYhwdcLC7WZVpQRvnhPpICPoqTMiftW7dyReVxeBZnPbfKljbdREWmdQtrZ uIH5IObuEYSGIK9/oSgzPIY+rIouP3iZxA7N22pxwGLXAIGtJdBkVCe2Gm+yVNNXh77PECZf ihD6R81l+dkDgsH7+G7i5vZZm8mzSHruOqXTc2QzocrCWehzKh77D3VzCewxclSjtKhZMv63 LMnQDV7riq96jT8G6S60bjq7Bt3PfxwNpKA8KBzuATNzXXkw6tIKBsQaeLsjwZqPymrHwqjN 7PiRE9ONkb0QKcQkiF5T/WnyXw2jcn7HHvjXeenHvYuMT8AAk3DsJQ7LgpOifx2g4FhpVRwa hL12WWu958FhXbhhnw4NDOSlVDile0iWBKq59Ss1VvFa8lLJNBp40W+01YVL0aGjjh1YwhGO 5ySOnB+fdtd0+AZXyxhBgv/DWVZAVwIv66eDlGhiTMuAIm2EyRjnFoivD3p01wt67UEPJ/lq P52qcBrsAGciZZV9M6OA47e7rDNoX6e2O7DIujGyWUKEg5AQO4l3fW2sR/2Aj4Qu1D8HMN8K 6xJ2+w81RCIn7TNQ==
  • Ironport-sdr: ym9en7AL96q1/tlI9Pes8pc+92zDTQATcF5cxVpqo/oDVfx+ZDPuTWGsNoHFLfyAqUxTdOEYvc /5XRfX+styWUWaKV/fr641IqpjZYBFPv3/xn1cfg4Inn0CvJ9gjspjMdIo+ZIPUq0YM2INYptb HU/aYlo3G6knB8G3XF7BW+thYOeqGOK0uvEJe5h6OvAI1k0D9qxhw4aJ7BiovKdpXLwY94pjZc D8vbgnpwgI4CKQXeGVJ9CP1yS3WVL3m24gpEV96NY39OfPyKmYm1zNzVV+kT1T7nD4zYjVgetY kcl1rmHVXjXNrHbJg7ScPVRS
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 29/09/2021 09:07, Jan Beulich wrote:
> On 28.09.2021 23:00, Andrew Cooper wrote:
>> The call to debugger_trap_entry() should pass the correct vector.  The
>> break-for-gdbsx logic is in practice unreachable because PV guests can't
>> generate #CP, but it will interfere with anyone inserting custom debugging
>> into debugger_trap_entry().
>>
>> Fixes: 5ad05b9c2490 ("x86/traps: Implement #CP handler and extend #PF for 
>> shadow stacks")
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
>

It turns out that I forgot to commit this patch, and it now needs a
Release Ack to go in.

It is very safe and obvious.  It is passing the wrong constant into a
debug function.

Luckily the impact is benign due to other properties of the logic, and
would only cause problems for people adding manual debug logic.

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.