[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH][4.16] x86/x2APIC: defer probe until after IOMMU ACPI table parsing


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Thu, 4 Nov 2021 15:21:03 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I470PyzyOWDbwozZat05vK0CLwjf8a8JYmNsm/kpx/I=; b=UdktcX2bIz5B1o8NECC1tg2h9sORR6pZLD33KfmMyL2ZVNduw+DAoOqjJAAjUnoJG95kHoY+YcUKvppzIy1xU8gUrlkDjb0QiHIu2diRDL3VvXMaN2c/ExydKe+LM0fDuG3L935wcQZ00KiqU1imV+tKdxBribEXDTmw0uByfcaHKLBpi0bKBkLb8KUSE8oIqBfyY8zZ4uMVLno0Cwiw3SnqIneV6QbnBcuJM84YglbG0G4RTdvt5qpnKR5E2+YjIsey/V6ciX/B4ZQJZGTN1/THGPxRqnaeigP/KAKytlLc6aYRIQQxOPGKaUXmMqNwuyMMPTPpPo5MaMNtUyxfuA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f8lsnT4xOzwnfCusm/f2ozuimFNoRWD3ndSs/rmZsEGqYF6z9LFPeJlxv9e6/Uco5Tg+1WvMPyoBGsH3uAPiLhqkUeSfnGLgmRGNciiRF1FhCkGxgOrSnHd/GlxlLdpBDibI5jDqoQ2WThB0LmjJKKcmoWmF7tcTclDGvZOGMuZnzk5Rfouqgbi9gtIZ7FCUYmr8Ig8Ja3k8CvVSS2uljMKUPs4sE7WFySh19wdfnbp1XKsJ78Kc38i2t1TUe8wHPImwnzQ3rbiXS/4S1cmE/Lym6Y2KZ5TiB17LfRGG0iX3mh7mVMSOjSVU51STwEUpclos/bw0qczI6SteE7tLJw==
  • Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxx>
  • Delivery-date: Thu, 04 Nov 2021 14:21:24 +0000
  • Ironport-data: A9a23:lDvqlKsPq+QaAAGzBlX6SAG/UefnVIhZMUV32f8akzHdYApBsoF/q tZmKTuFafrYZmf0LY8iPN+1800EuZPSy4VqHlQ6r3s8RHtE+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHhJZS5LwbZj29cx2YThWWthh PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ NpljcSrEyQVIbzwv6dGeDcEPQogI6xr9+qSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQQt2sm1TjEJf0nXYrCU+PB4towMDIY258XRauAP ZRxhTxHMBb5OgJGHG8sV4M6h82jqV6vSGFFtwfAzUYwyzeKl1EguFT3C/LKfvSaSMMTmVyXz krW8mK8DhwEOdi3zTue7mnqluLJhTn8Wo8ZCPu/7PECqF+Zy3EXCRYWfUCmuvT/gUm7M++zM GRNpHBo9/JrshX2EJ+tBHVUvUJooDYkA8EKMNEl+T2qifH/zVq3LTYaTxNOPYlOWNANeRQm0 VqAntXMDDNpsaGIRX/1yop4vQ9eKgBOczZcOHZsoR8tpoC6/dpt1k6nosNLSfbt1rXI9SfML ydmRcTUr5EaloY12qqy5jgraBr898GSHmbZCug6N19JDz+Vhqb5OORECnCBtJ6sybp1qHHb7 BDofODEvYgz4WmlznDlfQn0NOjBCwy5GDPdm0VzOJIq6i6g/XWuFagJvmojdRk0ap9UI2e4C KM2he+3zMUDVJdNRfUmC79d9uxwlfSwfTgbfqmMBjaxXnSBXFDep3w/DaJh92vsjFItgckC1 WSzKq6R4YIhIf0/llKeHr5FuZdyn3xW7T6DFPjTkkX8uZLDNSH9dFvwGAbXBgzPxPjf+1u9H hc2H5bi9iizp8WkPXWHr9VOdA9XRZX5bLivw/Fqmie4ClMOMEkqCuPLwKNnfIpgnq9PkfzP8 G37UUhdoGcTT1WdQelTQnw8Or7pQ7hlqnc3YX4lMVqygiBxaoez9qYPMZAweOB/puBkyPd1S dgDetmBXasTGmiWpWxFYMmvtpFmeTSqmRmKY3ivbg8gcsMyXAfO4NLlIFfirXFcEiqtuMIii LS8zQeHE4EbTgFvAZ+OOvKixl+8p1YHn+d2UxeaK9VfYhy0ooNrNzbwnrk8JMRVcUfPwT6T1 gC3BxYEpLaS/99poYeR3a3d9tWnCepzGEZeDlL317fuOHmI5HenzK9BTP2MIWLXWlTr9fjwf u5S1fz9bqEKxQ4Yr4pmHr935qsi/N+z9aRCxwFpEXiXPVSmDrRsfiuP0cVV7/Afw7ZYvU29W 16V+8kcMrKMYZu3HFkULQsjT+KCyfBLxWWCsaVreB33tH1t4b6KcUROJB3d2iVSIYx8PJ4h3 ep86tUd7Bayi0ZyP9uL5syOG79g8pDUv30bi6wn
  • Ironport-hdrordr: A9a23:LPfxU6PhpP0Fo8BcTsWjsMiBIKoaSvp037BN7TEXdfU1SL39qy nKpp8mPHDP5Ar5NEtOpTniAsm9qBHnm6KdiLN5Vd3OYOCMggqVBbAnwYz+wyDxXw3Sn9QtsJ uIqpIOa+EY22IK7/rH3A==
  • Ironport-sdr: btP4cNgu87rZpeILjyrlA/gpGzwyVIMKTg4Z0v5rH/h2gNu65dxmXEVQx2gIsj0/fBS1YopQBM E9hwc3xVLMUVHXo4+CS8Trf9z+g6w3wvOzFuJxYQbiaLT8U2pEHNaozWZ69zPhZbjq4IQ+kkqb A7RHMx0EMJX8S6eMfrBjX9sQ9SmkV7GtxjWDSQT5xxOFc6/u7xlC768gx/t0ch5S3bT0EwdKhl PFtDEfWlJDsFQ0DOJRg1BYeYm4UI6sooIZMU9fUcRQUUz/HnboI5qwvP46ZMBT42BcuNzC7xz2 sr8nXrrhAQ6RQwHO4NkFxQrq
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Wed, Nov 03, 2021 at 03:40:55PM +0100, Jan Beulich wrote:
> While commit XXXXXXXXXXXX ("x86/IOMMU: mark IOMMU / intremap not in use
> when ACPI tables are missing") deals with apic_x2apic_probe() as called
> from x2apic_bsp_setup(), the check_x2apic_preenabled() path is similarly
> affected: The call needs to occur after acpi_boot_init() (which is what
> calls acpi_iommu_init()), such that iommu_intremap getting disabled
> there can be properly taken into account by apic_x2apic_probe().
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

LGTM. I cannot find any dependency between acpi_boot_init and having
initialized the apic.

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.