[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH-for-4.16] tools/helpers: fix broken xenstore stubdom init
- To: Juergen Gross <jgross@xxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Thu, 4 Nov 2021 14:59:32 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Egel0g/qjpocY2MIuu9W8MEAndCTPcxwzC0ukdNqHfs=; b=kkHry3+LkBxc4zwyNrYLH/6oo9ZEKGlzDSLF6MklBrI4PhM56Z4p0fmwFcrh4KvwBGYsPpYGvlh07OwQgCegLgQ3xeK+5xCm+K+SYSBzvv4H3onwufMtkeb0EiMjHmmmy3/q3lW+TueSOlXS+LjitaPXAmZpHRlhmw5nKnIjTG2DJN91iYY3cfpwaOmiN9n9g3xI0U/ZKzu6qzMCapnR4IdOz1wco2esgamuE+4IGjEpgrpxKO3ojN7vaQGxEOz/n3MHTXo3fy12b4r6f5DqzI7mOiBSAAGsHNvN78/NMe7piO+b29iM3s8gsxd3E+5r+QaEWF4qtfs2TX0KnKg5dg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ClMZJbHnR9YSZkOZ3Za+1KYGzgXnLLgD3LbEQSNHWz12pCXsPlQAwO4A0jL5qrF+6SfYtd5eVg5JW17EAZNIMSMMuwbOFs9mZcNawHz/gJCK4Ybw2mCy+WaYXbGsqXbl7AyylhFjwRLWnqdIOz9iKhHWpZYC1rNlHFYmkIdPoqb451SaJASPKFpJXOhmbdzpTffP3hMDLMQjPNe4Ch017aRbTwEpJtBVf2mN+8vY5gKcCrgNbLXWHe8rlUoyJbfJJyihj4WTm5GnsxsHYDc0eQ4UX1f2y+YWY22kKe13NnxTaUFaPidIdk1jNwTvryZqZaQTMIBdnWUOXE2GeKMZJA==
- Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Thu, 04 Nov 2021 14:59:56 +0000
- Ironport-data: A9a23:JHycp6MM5tdyojLvrR1TkMFynXyQoLVcMsEvi/4bfWQNrUon0jIDy jEbCjyAOfuIa2Gmc9wkaYi/pB5SuMKAmtI2Twto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6bUsxNbVU8En540Eo/w7RRbrNA2rBVPSvc4 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYoxmvz89V9 Mh9jMC1GA4oNfHsvr8CfTANRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs 6VFdnZdNXhvhMrvqF6/YsBqit4uM4/AO4QHt2s75TrYEewnUdbIRKCiCdpwgWZo3J8XRqq2i 8wxdhk2bgTGPQ11eVISEJkiv7iwpkTbbGgNwL6SjfVuuDWCpOBr65D9PdyQdtGUSMF9mkeDu nmA72n/GgsdNtGU1XyC6H3Eru3AhyTgQ6oJCaa1sPVthTW72Wg7GBAQE1yhrpGRi1G8c8JSL VQO/SgjprR081akJuQRRDXh/iTC5ERFHYMNTatqs2lh15Y4/S61IDgbagJcWOV6sZ4/RDd29 nnSgP3AUGkHXKKudVqR8bKdrDWXMCcTLHMfaSJscTbp8+UPs6lo0EuRE48L/Lqdy4SsRGqum 2ziQD0W3u1L1aY2O7OHEUcrat5GjrzAVUYL6wreRQpJBSspNdf+N+REBbU2hMuszbp1rHHd4 xDoeODEtYji6K1hcgTXEI3h+5nztp643MX02wIHInXY323FF4SfVY5R+ipiA0xiL9wJfzTkC GeK51gMtcEOZCL6N/cmC25UNyjM5fKwfTgCfqqFBuein7ArLFPXlM2QTRfIt4wSrKTcuf5mY srKGSpdJX0bFb5m3FKLqxQ1itcWKtQF7TqLH/jTlk3/uZLHPSL9YepVYTOmM7FihIvZ8Vq9z jqqH5bTo/mpeLalOXe/HE96BQ1iEEXX8ris9JAHKLXee1U7cIzjYteIqY4cl0Vet/09vs/D/ 22nW18ez1z6hHbdLh6NZGwlY7TqNauTZ1piY0TA5H6khCouZ5iB9qAae8dldLUr7rU7n/V1U +MEa4OLBfEWEmbL/DEUbJ/cqo1+dUv02VLSbnT9ODVvLYR9QwHp+8P/ele9/ic5ESfq59A1p Ket112HTMNbFRhiFsvfdNmm00i14SoGgOt3UkaReotTdUzg/ZJEMSv0ivNrccgAJQ+anmmR1 hqMAAderu7I+tdn/N7MjKGCjoGoD+ohQRYKQziFte67bHCI8HCizIlMVPezUQrcDG6kqr+/Y eh1zu3nNKFVllh9rIchQa1gyrgz5oWzquYCnBhkBnjCc3+iFqhkfiudxcBKu6BAmu1ZtA+xV h7d89VWI+zUasbsEVpXLws5dOWTk/oTn2CKv/gyJUz74g5x/aaGDhoOb0Xd1nQFIesnKp4hz McgpNUSul62hRcdO9qbijxZqjaXJXsaXqR77pwXDecHUObwJo2utXAENhLL3Q==
- Ironport-hdrordr: A9a23:vpgrEawIEE6DzAySHYmgKrPxvOskLtp133Aq2lEZdPULSKOlfp GV8MjziyWYtN9wYhAdcdDpAtjkfZquz+8L3WB3B8bfYOCGghrUEGgG1+XfKlLbalXDH4JmpM Bdmu1FeafN5DtB/LbHCWuDYq8dKbC8mcjC74eurAYfcegpUdAF0+4QMHfrLqQcfnghOXNWLu v/2iMKnUvaRZxBBf7LeEXtEtKz6uHjpdbDW1orFhQn4A6BgXeB76P7KQGR2lM7XylUybkv3G DZm0ihj5/T/M2T+1v57Sv+/p5WkNzuxp9qA9GNsNEcLnHJhhyzbIpsdrWetHQeof2p6nwtjN 7Qyi1Qc/hb2jf0RCWYsBHt0w7v3HIH7GLj80aRhT/ZrcnwVFsBeoJ8rLMcViGcx1srvdl63q 4O9XmerYBrARTJmzm4z8TUVjlx/3DE4UYKoKo2tThyQIEeYLheocg050VOCqoNGyr89cQODP RuNsfB//xbGGnqLkwxhlMfguBEY05DWytvGiM5y4ioOnlt7T5EJnIjtY8idixqzuN7d3FGj9 60e5iA2os+CPP+VpgNcdvpd/HHfFAlcSi8Ql56Hm6XYJ3vG0i94KIfs49Frt1DRvQzvewPcd L6IQpliVI=
- Ironport-sdr: z4dxc8gzmRYjVxec+4u/Qc8uHtq9RTkvYHLqWTzVx32PCkZMq1iNLRYtzACCcOIe/C7XzThb/s XfaWNSFLB5ktCXVrDq2X0l15hegjD3dWLkOYAjIT4RAXuX14KX9u+OZqo0e1SD03wfMubC/fQ5 wYQk03Kjk/NNcqljGrrY/c1cHLLptsOTlBdqtSxp/5SlD1ZcyvqZsdaGQtb/qVU9gwuu2KQmqZ rkH39eypbzjQPLt6YL6u3QVwAbD010ht0bMYRlVwTRRV7gmtFN8wS0ogt4PJm0dw3zcLNkSzi3 HTkcer8BYHS6pozCv6bNfll6
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 04/11/2021 14:42, Juergen Gross wrote:
> Commit 1787cc167906f3f ("libs/guest: Move the guest ABI check earlier
> into xc_dom_parse_image()") broke starting the xenstore stubdom. This
> is due to a rather special way the xenstore stubdom domain config is
> being initialized: in order to support both, PV and PVH stubdom,
> init-xenstore-domain is using xc_dom_parse_image() to find the correct
> domain type. Unfortunately above commit requires xc_dom_boot_xen_init()
> to have been called before using xc_dom_parse_image(). This requires
> the domid, which is known only after xc_domain_create(), which requires
> the domain type.
>
> In order to break this circular dependency, call xc_dom_boot_xen_init()
> with an arbitrary domid first, and then set dom->guest_domid later.
>
> Fixes: 1787cc167906f3f ("libs/guest: Move the guest ABI check earlier into
> xc_dom_parse_image()")
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> Release-acked-by: Ian Jackson <iwj@xxxxxxxxxxxxxx>
This is all rather nasty, and really highlights problems with the
libxenguest abi, because you really ought to be able to ask "what ELF
properties do I have on my hand" without an implicit "and try to start
building a VM using it" on the side.
I agree this is probably the best thing to do right now.
Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
|
