[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/5] xen/xsm: Complete altcall conversion of xsm interface


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
  • Date: Fri, 5 Nov 2021 10:11:56 -0400
  • Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@xxxxxxxxxxxxxxxxxxxx; dmarc=pass header.from=<dpsmith@xxxxxxxxxxxxxxxxxxxx>
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1636121648; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=0AKKwH1oqvQxqu1OBKQOXJgoSAmhgOiLDohjGsZITb8=; b=gn55JsHsvWPkBAAKOl1/LcPMKvoLXwlKN+c9X62zt72YYyeipJ7Qay94X9T/o50Q2cuac0fMmkFG4zmQCVUF1Wdk+k7lbYPEiLJgafWJyC6MWi9qahGR2H8zGR4VXqJJamHuCytWozlHgxkTjBKnix6VFmRhLoBKc7DhzR1tvj8=
  • Arc-seal: i=1; a=rsa-sha256; t=1636121648; cv=none; d=zohomail.com; s=zohoarc; b=dm6iLrZyJuJ6LXB7iTxbow8qCxCxP05Kwruvp6qhovwE+1+DewgAM5n+3RfEYM+o1t21XrFjSCAPvAZ6xkUkakyvcDTiDyG+C9GhpAlGvQc6SjKqXG25vnOANQHp/9XCmWfNAQ22zpCxNp+MUsCe2nUDkL/iznUmsTDZlMJFaXY=
  • Cc: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
  • Delivery-date: Fri, 05 Nov 2021 14:14:18 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 11/5/21 9:55 AM, Andrew Cooper wrote:
With alternative_call() capable of handling compound types, the three
remaining hooks can be optimised at boot time too.

Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
---
CC: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
CC: Daniel Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>

I'm on the fence as to whether to declare this as fixing "xsm: convert xsm_ops
hook calls to alternative call"

I don't know about fixing but completing was accurate. I am fairly certain in one of the incarnations of the patch set there was a comment identifying that these were left remaining since compound types were not supported by altcall.

Regardless,

Reviewed-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>

v/r,
dps



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.