[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN][PATCH v2 1/1] Update libfdt to v1.6.1
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Mon, 8 Nov 2021 08:44:33 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Cl5otp6POmHQuRhU6Onl26NutVRtqwiPHyJhTKOaHOk=; b=S2xCcSrvH57WelId2LMfMTgx96fa6s0YuCTh7JVWkObddAWWJZKkMb//6q6hIB5OzFATp5xrC1cHkGqPnmhHAE9P2QpW2/2bNTOqoANSnHJ8ULCsaPk9lgZfcqto3dvaA/fZDCgnBr791nnO3bfY+ldW4Tx6XHRm+OaVwj7Qeo3uRHijl03WuGP0/x+iAyp66saDszKyIz+ufwNuDHzF4JT2kMXfBiTa2DWWpWPGRmGASAAJ1A0RujU0xFEFqKy/7RNEAaamMBYGQA5JnUMJ9Mo44Q+JdoMfDXN5kAOZIbVjmwmktGUGxKF8gbNPAVNU7SDALSuEnoBS6WROwyn3fA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MYUhHGfQMnYLg/CmiNo3b4TOvuIlePGBK61ar+Ms0mmOxqj/lQhnmCk5s/utd59RcFITgbG19ytcrlO59/hHgTG8TLb0DNq8BIhu5DEXLJPG4S3WqJJ4D1ym35oWYDiwuVfEqIIvX0ZZofWrjz2xQCoHQBBo17+1f10AhCSu/ORj2pwTudOQ3aWZLyQy4bKdKh5+QICdSjrMvxWduw4gN/ftVPsTxFG8s7UxjmjN++F08aLx4dXcChKXhZzUmVzQjghyM9FkuBj2Qpg+5BdJDcVYiIuZT4xkM2LJrWtpap6972XTfZY2kkBc7J4yFCuEAPKIqbTjBIICgNDk4Dr9TQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>, Vikram Garhwal <fnu.vikram@xxxxxxxxxx>
- Delivery-date: Mon, 08 Nov 2021 08:45:01 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHX0UQblDQwk25oXUS4+EmFAqHUdKv1BFoAgARSEICAAAC7AA==
- Thread-topic: [XEN][PATCH v2 1/1] Update libfdt to v1.6.1
Hi Jan,
> On 8 Nov 2021, at 08:41, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 05.11.2021 15:43, Bertrand Marquis wrote:
>>> On 4 Nov 2021, at 06:19, Vikram Garhwal <fnu.vikram@xxxxxxxxxx> wrote:
>>>
>>> Update libfdt to v1.6.1 of libfdt taken from git://github.com/dgibson/dtc.
>>> This update is done to support device tree overlays.
>>>
>>> A few minor changes are done to make it compatible with Xen:
>>> fdt_overlay.c: overlay_fixup_phandle()
>>> Replace strtoul() simple_strtoul() as strtoul() is not available in Xen
>>> lib
>>> and included lib.h.
>>> Change char *endptr to const char *endptr.
>>>
>>> libfdt_env.h:
>>> Changed path for config.h and stdbool.h. Remaining Xen changes to
>>> libfdt_env.h carried over from existing libfdt (v1.4.0)
>>
>> I can confirm that you updated all sources to version 1.6.1 and the changes
>> are actually limited to what you said here.
>>
>> But you forgot to update the version.lds file to sync it (which was done on
>> the
>> previous update to 1.4.0). Could also update version.lds ?
>>
>> I can also confirm this is compiling for arm32, arm64 and x86.
>
> Since you mention it explicitly, I'm curious: x86? Do you have a
> custom patch in place to enable device tree (and hence libfdt
> building) there?
No I do not, I should have been more clear in my sentence.
I am testing with the patch that the 3 architecture are compiling with
the default config. So in this case for x86 the modified files have not
been compiled but the patch is not breaking x86 build.
Cheers
Bertrand
>
> Jan
>
|