[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/6] x86/APIC: drop clustered_apic_check() hook
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Mon, 8 Nov 2021 12:02:40 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sX3OeACX5Fqjtedh1NCeUY4fRWwpMBz0D3U4t+oxVvU=; b=Q0Fgv/gxOfwKI5I1mfpR5WfHUH/a6Mx1T/crahAiZWrAButHAShg3PgvHteuYcvI4y2oDZD94+w9d04OEwB2xKXj5fflqZEAK6V5/ENOIe8yGjqk+T6R4z92QpNfUU9p9kQyYEaStSMUbr0Hp0pP1caIyXCGRqCm0Pj5dCsUFM+hXr4JDTS8xo23uBkDcV3AbOpaLJIuYkU5t3QmrYNS85S7H+yJU2I7Jpi7tbxjHeHDWT1/K1b20jk4IAPpq4iShQGOjTOFY4zRSl2zt1qPngBVYler6EPPx4ezoDveToqsHKchKYFnz/TCt9BqBshxOF9hK4JzhHxiQZBApnpN1Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cX8U4yfmWKCJ2dHfaTDGF748Ltb0j4bFSEnK5vbb6Lg7yBuNPkTuHFr9h+tFAPfzveR1DuFWf+ZwtAqPkdDTt1v/O82xLPw0UVQjnBMH3MMV7MVVGv0oQ4mElBF6kkcOR0miw94HRmzgYvvSPgBRKdv3ifGXyE0bXeH7bD4sj+mWquM0xropNgQfUU0VNP61kKAq9ZkGwyS8eW+urITbSQdH83RutaBSffUpLMLSIvnPLqWOT4h4gNXduTQpODkUjeYt266vgYiYwoDsMWmctZP874X5CWMqXrYJs/zCkdoeiL44jLxuiVTJSgiPmw30Mf/w1T6xRcQuydd8S/0I2Q==
- Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Mon, 08 Nov 2021 11:03:06 +0000
- Ironport-data: A9a23:aUqO16wB55s5QVvGVS16t+f8wSrEfRIJ4+MujC+fZmUNrF6WrkVTz WMfWWiAPv3bNmr2c9t+OoW2/E5V68TSnNdjQQNvrCAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAuLeNYYH1500s6wrZp2tcAbeWRWGthh /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt/twy NsVnLGRcDgOOvH0ueBEajpnMT4raMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr 6ZBbmlQMFbT3Ipaw5riIgVort4kI8TxepsWp1lrzC3DDOZgSpfGK0nPzYIHgmdq25kWdRrYT 886WXldPQuQWDpWJngKUKBije7yqVCqJlW0r3rK/PFqsgA/1jdZz7zFINfTPNuQSq19jkue4 27L4Wn9KhUbL8CEjyqI9Gq2ge3Clj+9X5gdfJW6/PN3hFyYxkQIFQYbE1C8pJGEZlWWAowFb RZOo2x38PZ0pBfDosTBswOQi3+EsEY1dvtpLMo+tDmszvPtwDm7GT1RJtJeU+AOuMgzTD0s8 1aGmdL1GDBi2IGopWKhGqS89m3rZ3VMRYMWTWpdFFZevYG/yG0mpkuXFo4LLUKjsjHi9dgcK RiupTN2ubgchNVjO06TrQGe2GLESnQko2cICuTrsoCNs1sRiG2NPdXABb3nARFodtfxc7V5l CJY8/VyFchXZX13qASDQf8WAJai7OufPTvXjDZHRsd6qW/0oif/IdAOvFmSwXuF1e5eKFfUj LL741sNtPe/wlPzNcebnL5d++x1lPO9RLwJp9jfb8ZUY4gZSeN01HoGWKJk5Ei0yBJEufhmY f+zKJ/wZV5HWfUP5GfnHI81jO50rh3SMEuOHPgXOTz8iuHADJNUIJ9YWGazghcRtvrc8VqEr 4YGXyZIoj0GONDDjuDs2dd7BXgBLGQhBICwrMpSd+WZJRFhFn1nAPjUqY7NsaQ590iMvuuXr Hy7RGFCz1/z2S/OJQmQMygxY7LzR5dv63k8OHV0b1qv3nEiZ6ep7bseKMRrLeV2qrQ7wK4mV eQBduWBHu9LFmbN9QMCYMSvt4dlbhmq216DZnL3fDglcpd8bAXV4du4LBD3/SwDA3Pv58szq rGtzC3BRp8HS1gwBcracqv3nViwoWIciKR5WE6Reotff0Dl8Y5LLS3tj6Bof5FQeEubnjbDj lSYGxYVo+XJsrQZytiRiPDWtZqtHst/AlFeQzvR44GpOHSI5WGk24JBDrqFJGiPSGPu9ay+T uxJ1PWgYuYflVNHvocgQbZmyaUyu4nmq7NAl1k2GXzKaxKgC696I2nA1s5K7/UfyrhcsAqwe 0SO5tgFZunZZJK7SAYcdFg/c+CO9fAIgT2Dv/06LXLz6DJz4LfaA15ZOAOBiXAFIbZ4WG//L TzNZCLCB9SDtycX
- Ironport-hdrordr: A9a23:rMiZxKz7zRqbww3KK4oRKrPxtuskLtp133Aq2lEZdPULSKOlfp GV8MjziyWYtN9wYhAdcdDpAtjmfZr5z+8O3WB3B8beYOCGghrSEGgG1+XfKlLbak/DH4JmpM Jdmu1FeaHN5DtB/LfHCWuDYq8dKbC8mcjC74eurAYccegpUdAZ0+4QMHfkLqQcfnghOXNWLu v52iIRzADQBkj/I/7LTEUtbqzmnZnmhZjmaRkJC1oO7xSPtyqh7PrfHwKD1hkTfjtTyfN6mF K13zDR1+GGibWW2xXc32jc49B/n8bg8MJKAIiphtIOIjvhpw60bMBKWqGEvhoyvOazgWxa3e XkklMFBYBe+nnRdma6rV/E3BTh6i8n7zvYxVqRkRLY0IXEbQN/L/AEqZNScxPf5UZllsp7yr h302WQsIcSJQ/cnQzmjuK4Fi1Cpw6Rmz4PgOQTh3tQXc81c7lKt7ES+0tTDdMpAD/60oY6C+ NjZfusqsq+SWnqLEwxg1MfguBFBh8Ib1K7qwk5y4OoOgFt7TBEJxBy/r1aop8CnKhNPaWsqd 60dZiAr4s+PPP+W5gNc9vpcfHHeVAlfii8RV56AW6XXJ3vaEi94KIe3t0OlZWXkdozvd0PpK g=
- Ironport-sdr: /an9u6BEEOUFEdXz/7dxME64kaQkOTfeSQ6JPPXeGASHbJwlzUOs6yTb/wF0VCLYGMIdMooFln HT2xDhKTZiZISVCPVa8YhZ27sSRTv8Y0KvMEm7p1R8o6cVIiw60lTTp3oatBfKwZj9F+eEICHO zYdggowLN6IJ6mDKDHw38lSNIGx6iZgKLkjWgxC7M9W514IW9e5y5BD5On1k6JfRXM6TLWHKG/ DI6m9ME8cPFkBVPqOB5FnzniwW7l9ZoWvFVcRnfHDsJtPs6+tUlnSsjqi2Z0wk5Zq/wD0AKCFb u2iUoWeCO2nLmv693a0Y0S5h
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Fri, Nov 05, 2021 at 01:34:12PM +0100, Jan Beulich wrote:
> The hook functions have been empty forever (x2APIC) or issuing merely a
> printk() for a long time (xAPIC). Since that printk() is (a) generally
> useful (i.e. also in the x2APIC case) and (b) would better only be
> issued once the final APIC driver to use was determined, move (and
> generalize) it into connect_bsp_APIC().
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> ---
> v2: New.
>
> --- a/xen/arch/x86/acpi/boot.c
> +++ b/xen/arch/x86/acpi/boot.c
> @@ -674,9 +674,7 @@ static void __init acpi_process_madt(voi
> error = acpi_parse_madt_ioapic_entries();
> if (!error) {
> acpi_ioapic = true;
> -
> smp_found_config = true;
> - clustered_apic_check();
> }
> }
> if (error == -EINVAL) {
> --- a/xen/arch/x86/apic.c
> +++ b/xen/arch/x86/apic.c
> @@ -243,6 +243,12 @@ void __init connect_bsp_APIC(void)
> outb(0x70, 0x22);
> outb(0x01, 0x23);
> }
> +
> + printk("Enabling APIC mode: %s. Using %d I/O APICs\n",
I don't think it makes sense to prefix APIC with 'x' or 'x2' here, as
we already print the APIC mode elsewhere?
> + !INT_DEST_MODE ? "Physical"
> + : init_apic_ldr == init_apic_ldr_flat ? "Flat"
> + :
> "Clustered",
> + nr_ioapics);
> enable_apic_mode();
This also seem to be completely unneeded? I guess it would be cleaned
in a further patch.
Thanks, Roger.
|