[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 1/6][4.16?] x86/x2APIC: defer probe until after IOMMU ACPI table parsing


  • To: Ian Jackson <iwj@xxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 8 Nov 2021 16:13:43 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lPCyICozdf2UepPQBEqmMJz8QFZjBQ04YYoBzOsqA5c=; b=S4V8+n64WFWsTydZdKsAU4J6jCJL/iGHJ3/j+Id6inIQ4/eeYalrVXgjLzv+p7YIA1M0TOA5M3ZYgGfZ65P6fwv3EbBRd/elpz8NxQIxdnxKimbC5EbY6DzDarW3Mjr+vEniozCYZi6ZY7DnHRkH8xawPm0k9dVGS/NqJ7EpS4/1FIX6L7SGd2ELm/8FEMnkz81gzgNPWdJ4Xr6vAzZXgF1BJGE53fj/5Ks6yPA2RGg5lVoqqiLAoJZddLzrN0kYPDYEI0I+4ADKTYoYEIoDFMdZFifEaGjOOSF9hxTB+XjrNjVWHvF/aT6TIE0z+QIo37JUxhX/QqgT7+PHrCeLwQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KpoyInAuDeXfy0qiSBKlsRtfy4iOFW0lxBxlaudOPQ6OPgVjBGvDG2hiIqnOSaNewaMnQLJudJN3lLUibrZgy2QtX3/avQfuFUSynLnykJYMQeotYEgiTzzw6j7Z7WpjuqEXAkJ2iN3F73bkL4iNjRPO8/3lyOF4djNYdsUfZr7xJUySEprqFPsQrEfyZ8lZN4yoZ23MYXwFAYhULqRd9GAx4O5+ErIlOQgZROWotk1nZagPgtJ2Ok/Z7xe48LLKf/ny38O0HP8uP/mWTNayDoB/mBAybOqFDFAmr+woXFlXogorDBFtN1hnUXkxMysJU6T8NRgPkYVM0FVs81BRBg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <royger@xxxxxxxxxxx>
  • Delivery-date: Mon, 08 Nov 2021 15:14:01 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 08.11.2021 16:04, Ian Jackson wrote:
> Jan Beulich writes ("Re: [PATCH v2 1/6][4.16?] x86/x2APIC: defer probe until 
> after IOMMU ACPI table parsing"):
>> On 05.11.2021 16:47, Ian Jackson wrote:
>>> This part confused me.  Under what circumstances would we backport
>>> this ?  AIUI it would be backporting a potentially-fragile and
>>> not-readily-testable bugfix, for a theoretical scenario with a
>>> straightforward workaround.
>>
>> Well, I've said "candidate" for this very reason: To me, every bug
>> fix is a candidate. Whether risks outweigh the potential benefits is
>> then influencing whether to _actually_ take the change. A reason to
>> take it despite the available workaround might be that
>> "straightforward" doesn't also mean "obvious" here. IOW once you
>> know what to do, doing so is easy. But one first needs to arrive
>> there.
> 
> Could we not do a smaller fix that would print something in the boot
> output, mabye ?  That would be a lower risk change.

Hmm, maybe something could be done, but at the risk of getting the
conditions there wrong (and hence having false positives and/or
false negatives, confusing users at best) and with likely a clumsy
log message ("abc ran before xyz"), suggesting that we actually
know how to do better. IOW - I'd rather not go this route, and it
would feel better to me to simply defer this change to post-4.16
if we deem it too risky to put it in now.

> So far, I think the tradeoff here isn't looking very good: a risk of
> unclear magnitude for many users, vs a hard crash at boot for a set of
> users we believe to be empty.
> 
> As ever, feel free to contradict me if I have the wrong end of one of
> the many sticks here...

I think you've got it quite right. I did put the question mark in the
tag specifically to make clear that while I'd like this to be
considered, I'm myself not convinced the risks outweigh the benefits.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.