Re: [PATCH v2 for-4.16] xen/arm: allocate_bank_memory: don't create memory banks of size zero

[Ian Jackson <iwj@xxxxxxxxxxxxxx>]

To the maiontainer who will review this: could you
please consider these comments as part of your review:

Stefano Stabellini writes ("[PATCH v2 for-4.16] xen/arm: allocate_bank_memory: 
don't create memory banks of size zero"):
> From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
> In regards to inclusion in 4.16.
> 
> If we don't fix this issue in 4.16, default usage of Xen+Linux won't be
> affected.
> 
> However:
> - Non-Linux OSes that cannot cope with zero-size memory banks could
>   error out. I am not aware of any but there are so many out there in
>   embedded it is impossible to tell.
> - downstream Xen calling make_hypervisor_node for DomUs will crash
> - future Xen calling make_hypervisor_node for DomUs will have to make
>   sure to fix this anyway
> 
> If we commit the patch in 4.16, we fix these issue. This patch is only 2
> lines of code and very easy to review. The risk is extremely low.
> 
> Difficult to say what mistakes could have been made in analysis and
> preparation because it is a trivial if-zero-return patch, which is
> likely to fix latent bugs rather than introducing instability.

Then, subject as usual to satisfactory maintainer review,

Release-Acked-by: Ian Jackson <iwj@xxxxxxxxxxxxxx>

Thanks,
Ian.