[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3] xen/arm: don't assign domU static-mem to dom0 as reserved-memory



Hi Ian,

On 11/11/2021 13:33, Ian Jackson wrote:
Julien Grall writes ("Re: [PATCH v3] xen/arm: don't assign domU static-mem to dom0 
as reserved-memory"):
Hi Stefano,

On 10/11/2021 20:18, Stefano Stabellini wrote:
From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>

DomUs static-mem ranges are added to the reserved_mem array for
accounting, but they shouldn't be assigned to dom0 as the other regular
reserved-memory ranges in device tree.

In make_memory_nodes, fix the error by skipping banks with xen_domain
set to true in the reserved-memory array. Also make sure to use the
first valid (!xen_domain) start address for the memory node name.

Fixes: 41c031ff437b ("xen/arm: introduce domain on Static Allocation")
Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
Release-Acked-by: Ian Jackson <iwj@xxxxxxxxxxxxxx>

Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>

FTAOD: I don't see a for-4.16 tag here.  So I think this is targeted
for post-4.16 ?  But I wonder if it ought to be considered.  I don't
understand the impact of the bug that is being fixed here.

The first version of the patch [1] was tagged with for-4.16 and contains the rationale.

I was thinking to commit it because it already contains your release-acked-by. Can you let me know if it still stands?

Cheers,

[1] https://lore.kernel.org/xen-devel/24970.20802.96908.223297@xxxxxxxxxxxxxxxxxxxxxxxx/T/#m058f2d243f6670ef48e77f40c25ac0115f0dae74


Thanks,
Ian.


--
Julien Grall



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.