[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2.2 07/15] xen: generate hypercall interface related code


  • To: Juergen Gross <jgross@xxxxxxxx>
  • From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Date: Thu, 11 Nov 2021 16:04:47 +0000
  • Authentication-results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, "Ian Jackson" <iwj@xxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Thu, 11 Nov 2021 16:05:29 +0000
  • Ironport-data: A9a23:LiPyXqlsw0QXpN9D3R7/I+Lo5gwRIURdPkR7XQ2eYbSJt1+Wr1Gzt xIWCmnSMvfYYzfzc4pya9y28UIP6pTWmtZjHgo6qioyEyMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA187IMsdoUg7wbdg29cx2YHR7z6l4 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4 OpNroPhTCMUB73nlrkCbkRASRpaMKITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq 6ZecmpUKEne2aTmm9pXScE17ignBMDtIIMYvGAm1TzDBOwqaZvCX7/L9ZlT2zJYasVmQKeDN 5BJMWEHgBLoWzJjHEYGNp8Ejr2hq3CkWhF0iAqSjP9ii4TU5FMoi+W8WDbPQfSIWMFUk0Cwt m/AuWPjDXkyL8eDwDCI9natgO7nni7hXo8WUrqi+ZZCn1m71mEVThoMWjOTo/O0l0q/UNJ3M FEP92wlqq1a3E6kVN7mRDWjvWWJ+BUbXrJ4A+A8rQ2A1KfQywKYHXQfCC5MbsQ8s807TiBs0 UWG9/voGj5HoLCTUWia9LqfsXW1Iyd9EIMZTXZaF01fuYCl+dxtyEKUJjp+LEKrpuL1Ai6hx hS3lTgViegMsJMTjZ6f8F+S1lpAuaP1ZgIy4wzWWEes4QV4eJOpauSU1LTL0RpTBN3HFwfc5 RDoj+DbtblTVs/VyERhVc1UROnxj8tpJgEwlrKG83MJ0z22s0CucolLiN2VDBc4a51UEdMFj aK6hO+w2HOxFCf1BUOUS9joYyjP8UQGPY20PhwzRoAeCqWdjCfdoElTibe4hggBanQEn6AlI ou8es2xF3scAqkP5GPoHLlAj+50ln1hmjy7qXXHI/KPiOv2iJm9E+dtDbdzRrphsPPsTPv9r 76zyPdmOz0ACbajM0E7AKYYLEwQLGhTOHwFg5c/SwJ3GSI/QDtJI6aImdsJItU594wIxrag1 izsASdwlQug7UAr3C3XMxiPnpu0Bs0hxZ/6VARxVWuVN48LPdzysfxBLsRvJtHKNoVLlJZJc hXMQO3Yatwnd9gN0251gUDVoNMweRK1qxiJOib5MjEzc4Q5H17C+8P+fxup/y4LV3Llucw7q rym9wXaXZtcGFgyUJeIMKqinwGroHwQuONuRE+UcNNdT1rhrdpxICvrg/5pf8xVcUffxiGX3 hq9CAsDobWfuJc89dTE3PjWr4qgH+ZkMFBdGm3XseS/OSXApzLxyo5cSueYOzvaUTqsqqmlY OxUydD6MeEGwwkW49YtTe4zwPtntdX1prJcwgB1J1nxbgymWuF6P32L/chTrakRlLVXjhS7B xCU8d5ANLTXZM68SAwNJBAoZ/io3O0PnmWA9uw8JUj36XMl/LeDVkkObRCAhDYEcelwOYIhh +wgpNQX+0q0jR9zaoSKiSVd9mKtKH0cUvp46sFGUdGz0gd7mEtfZZH8CzPt5MDdYtpBBUAmP zuIifeQnL9b3EfDLyI+GHWlMTCxXnjSVMSmFGM/Gmk=
  • Ironport-hdrordr: A9a23:2c0Ds6uyrE68FYg7yHG5N1rD7skDdNV00zEX/kB9WHVpmszxra GTddAgpHjJYVcqKRUdcL+7VJVoLUmyyXcx2/h2AV7AZniChILLFvAA0WKK+VSJcEeSygce79 YDT0EXMqyIMbEQt6bHCWeDfeod/A==
  • Ironport-sdr: JWe+8uhq33k9f5OneyswnZc7zdlRqug28PkSh7VsEP3fTAGnK+D0Gp/CTjnkQEoke2w07mER/n kcFzFonGcrbtwb7yR+EUWzL6ZbEOwGF3qCyPKNTj1YNmwC0KK30JJOytLIpa3qd1v3R9u/qP97 28GqIxYlhdyojcR+kT6OjA5V+deujqkD75+q1yj2cQrWsg7F/A5T+C5MapbegO59CH7J+h1JBS O+smYgLuWnfBdKqLZR3Kn8rI5aSQ4ESOumy2qG0yfUlGl45fm4UV3yrBffayWbuHIINWcGbnQV RPhsenn+irhfZhbqwtizHw4/
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Wed, Nov 03, 2021 at 11:20:59AM +0100, Juergen Gross wrote:
> diff --git a/xen/Makefile b/xen/Makefile
> index a3189eb47c..dfdae47e74 100644
> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -405,6 +406,7 @@ $(TARGET): delete-unfresh-files
>       $(MAKE) -f $(BASEDIR)/Rules.mk -C include
>       $(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) include
>       $(MAKE) -f $(BASEDIR)/Rules.mk include/asm-$(TARGET_ARCH)/asm-offsets.h
> +     $(MAKE) -f $(BASEDIR)/Rules.mk include/xen/hypercall-defs.h
>       $(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) $@
>  
>  # drivers/char/console.o contains static banner/compile info. Blow it away.
> @@ -466,6 +468,14 @@ include/asm-$(TARGET_ARCH)/asm-offsets.h: asm-offsets.s
>         echo ""; \
>         echo "#endif") <$< >$@
>  
> +quiet_cmd_genhyp = GEN     $@
> +define cmd_genhyp
> +    awk -f scripts/gen_hypercall.awk <$< >$@
> +endef
> +
> +include/xen/hypercall-defs.h: include/hypercall-defs.i 
> scripts/gen_hypercall.awk FORCE
> +     $(call if_changed,genhyp)
> +

Is there a reason to generate "hypercall-defs.h" here? Could this be
moved to include/Makefile instead?

Then, when moved to include/Makefile, I think you would need to add both
"xen/hypercall-def.h" and "hypercall-defs.i" to $(targets) to avoid them
been rebuilt needlessly.

Thanks,

-- 
Anthony PERARD



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.