[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/6] VT-d: properly reserve DID 0 for caching mode IOMMUs


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Fri, 12 Nov 2021 12:23:58 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Vcl89wRbh/zYNOE8yCgf6W7KaYUj0TQbn560PdhObcM=; b=A2UyyWOwm4sqKRLJIEsoXs7ltkbryiQ8y+4npH3fG6gjUZ9ES2mi4TJMs4NqCcnq3BNlIfq90UyExizsIddzAg1MSUjho1bs2UZRvThR7Mbpj8J4KYBfoY5Afm3wPN65H3X02WWS25yzC1YKNK4t/MCVRGg81XsMVCfKl+dlelL/r7JKmI5ALcXViY786jeiUlYJfFFyI1U6cTRPC6SjASNi/Y+3+UPZGwf+nIiJH3t7HE5aFg8QvQPdUuvBz5uDQiH9RkiLGEc5jK2qZQRaF58YHTaNksnOVpbgJpHMJmmr1gJ5gCTm4Y3wjiTTSr3g5NdWzBNahb0qFr/U83G75g==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d1G4HfgRGhwmdKKqfKsSchiNxqr0XBVgzie7psKilbc9pfB8y3mxDiQVJFnadm0OXdP9aHS/Gdqv+eeDpSTI3E6kuK1SDe91L2jRBU5FlxInCtW6Uf4shDxPR9OWsIR1zP4BzFYdqIqQiizK0T9sThnOz1g3GbZjLxtuksb6BVsWN5/1NxAtA0KV5jm6HMcBD1PmSrSQpWVFX8jP5N53VL7Y8MLFhUnk1GHZl2mCxrCkdeu0Y73sezTcwLTua/fhwxD9x0k60MsBkR8zP0Vqvm90G31q5+btN1aQOLusnnvurNyCzLbct3k3dmewiCQTtdrYmLLp/DfutxbzKpHyUA==
  • Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>
  • Delivery-date: Fri, 12 Nov 2021 11:24:33 +0000
  • Ironport-data: A9a23:ZKO1q6CoXYBEVBVW/8jkw5YqxClBgxIJ4kV8jS/XYbTApDom0GYGz DRNW2mPb/iMZTT3fIxwPI2+oUtVu5+AzoMxQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WLGs1hxZH1c+EX540Eg7wYbVv6Yz6TSHK1LV0 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/oAWktusy4 fR2s4WAaAEtPerLu7VEekwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr KFGbmBWBvyAr7veLLaTUO5ji95lNMD2FIgepmth3XfSCvNOrZXrHvqVvYcJhWdYasZmRun1Z PYaUThWagnLehxBYGtUGZlhg7L97pX4W2IB8w/EzUYt2EDQwRJw1v7xMdPTUt2MWchR2E2fo wru72n/Rx0XKtGb4T6E6W63wP/CmzvhX4AfH6H+8eRl6HWRzGEODBwdVXOgvOK0zEW5Xrpix 1c8o3R06/JorQryE4e7D0bQTGO4UgA0cOp9OtZ5wSC2zLPkwgCdBS8DbW8YQYlz3CMpfgAC2 liMltLvIDVgtryJVH6QnoupQSOO1Ts9djFbO3JdJecRy5y6+dxo0EqTJjp2OPft1oWdJN3m/ 9ydQMHSbZ03hNVD6ai09Euvb9mE9smQFV5dCuk6swuYAuJFiGyNO9PABbvzt68owGOlor+p5 iVsdy+2trBmMH11vHbRKNjh5Znwjxp/DBXSgER0A74q/Cm39niocOh4uW8lehk0bJxfIm60O ic/XD+9ArcJYRNGioctM+qM5zkCl/C8RbwJqNiIBjaxXnSBXFDep3w/DaJh92vsjFItgckC1 WSzKq6R4YIhIf0/llKeHr5FuZdyn3xW7T6DFPjTkkX8uZLDNSH9dFvwGAbXBgzPxPjf+1u9H hc2H5bi9iizp8WiOHSKqtBKcghRRZX5bLivw/Fqmie4ClMOMEkqCuPLwKNnfIpgnq9PkfzP8 G37UUhdoGcTT1WeQelTQnw8Or7pQ7hlqnc3YX4lMVqygiBxaoez9qYPMZAweOB/puBkyPd1S dgDetmBXasTGmiWpWxFYMmvtpFmeTSqmRmKY3ivbg8gcsMyXAfO4NLlIFfirXFcEiqtuMIii LS8zQeHE4EbTgFvAZ+OOvKixl+8p1YHn+d2UxeaK9VfYhy0ooNrNzbwnrk8JMRVcUfPwT6T1 gC3BxYEpLaS/99poYeR3a3d9tWnCepzGEZeDlL317fuOHmI5HenzK9BTP2MIWLXWlTr9fjwf u5S1fz9bqEKxQ4Yr4pmHr935qsi/N+z9aRCxwFpEXiXPVSmDrRsfiuP0cVV7/Afw7ZYvU29W 16V+8kcMrKMYZu3HFkULQsjT+KCyfBLxWWCsaVreB33tH1t4b6KcUROJB3d2iVSIYx8PJ4h3 ep86tUd7Bayi0ZyP9uL5syOG79g8pDUv30bi6wn
  • Ironport-hdrordr: A9a23:qcAp0KD4u0yONp3lHeg3sceALOsnbusQ8zAXPh9KJiC9I/b1qy nxppkmPH/P6Qr4WBkb6Le90Y27MAnhHP9OkPIs1NKZMjUO11HYTr2KgbGSpgEIXheOi9K1tp 0QDZSWaueAdGSS5PySiGLTc6dCsai6GeKT9J/jJh9WPH5XgspbnmFE42igYylLrF4sP+tEKH PQ3LsMm9LmEk5nG/iTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1SvV Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfpWoCoZ 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8DLeiP28YAh/J9tKhIpffBecwVEnpstA3K VC2H/cn4ZLDDvb9R6NpuTgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed MeQv003MwmMm9yUkqp/FWGmLeXLzEO91a9Mwc/U/WuonhrdCsT9Tpd+CQd9k1wgq7VBaM0oN gsCZ4Y542mePVmGp6VNN1xMfdfNVa9My4kEFjiaWgPR5t3cE4klfbMkcEIDaeRCdo18Kc=
  • Ironport-sdr: JEgU0JgjJvFTs9LSpB1tEv4OB/BNw6h9HxMDYbn4z++tRxpMUzj2H/65efqQtnE0ct0lYRPyGB qEGCKceu5fLSVnF6dypYZSYRdpUDi5X5VFvY38Zl67B0RiezH7gLUYRmNN2ipY0m9uSy4Iayrg 7zFHt5ksozOPXtjAxAUpMhbdJ2svCkAfLP6Hvo3aLXrMejWqQ0sgs1Iw53yQBRjjcB3MQ+x4qI uiYY0ZJbc0OKZBtwQoPGhMD6jT1U/f2+mMUb3BXUhPsZhl6QLf3aPRHBASzqKP/8OvH8iV9DxP rq+c4bgu77KOlfrzw9h82MI2
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Fri, Nov 12, 2021 at 10:47:59AM +0100, Jan Beulich wrote:
> Merely setting bit 0 in the bitmap is insufficient, as then Dom0 will
> still have DID 0 allocated to it, because of the zero-filling of
> domid_map[]. Set slot 0 to DOMID_INVALID to keep DID 0 from getting
> used.

Shouldn't the whole domid_map be initialized to DOMID_INVALID to
prevent dom0 matching against any unused slot?

Similarly cleanup_domid_map should set the slot to DOMID_INVALID.

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.