[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/6] VT-d: don't leak domid mapping on error path


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Fri, 12 Nov 2021 14:42:09 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eZKhjLwJkuh0qvDZ4NicqjzuNzNEktNy1WoaRJC4Bvw=; b=jnfl5lJJQDFC910TI3PJrxhhN5hxJAZu+zRyNdkCpYK4+iVeozV4vJxJqi++vSdax37JgXFzkhhVWO0vRaJHpY2VNWdxedomOpNjhHEdh6oCTjoasWPvnBHkCFqXUwDmJXgOosb38LSX+kLK7W2fXBOIra5sUN+lJQEovzYWmAY0wC5nUdG/+LzLRxcAy8xTmNa/sbn6kxXwDPgi88qGyhtv9Q1kEkiP0TSV2qjwAqFlpt+GftQuPKyqqCX9E4WRBvf2lE/0jczhS+v1gKFywymxnBpWoZeDJ8roZzVL00B1Z8dv/xu+EhXj24UNIVwoZOC+m2IiV/iw1AOhjcTulg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FSJWYYhUQ0NhL7G/wSB7P+HawXZaajUoZuzKrb4BtG8HWXi3prxmhkFCAy1kWZlJGJG1v2IwLJkyz3GwvrEn8PNJM1i8EVnG9JAOBprq3U1icX3dcd4Fok+SRF9u1nDwOXXh7MIaFF6DQVRC696HY7QhsFhNu0W2Agjca1ivKe9vvuraTmQgNlr6wx8egYMaWOPL24JGz7BMoWOgvqrsEWgSj4HgPb6TcjZjtAgMEIaiim4EKC9tM0A/6bq2CFLZAv1xQZH+8OY2RFkfMtZtZlQULzpyi3PHnJPK52wJD+Clhzw5rsI4ebIg6RjkVR+FvjmettU+/SIIuBnnP1uMaQ==
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>
  • Delivery-date: Fri, 12 Nov 2021 13:42:48 +0000
  • Ironport-data: A9a23:poE3A6venrwFZP8Mg11fR0UXaufnVLZZMUV32f8akzHdYApBsoF/q tZmKTuFOazYMWX3c4pxPIyy/UIPvp/TyN5nSVRurC8wES4S+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHhJZS5LwbZj29cx2ILhWWthh PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ Npltbu9ST8zOoT1hsMGUkh1LCU5MadD5+qSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQQt2sm1TjEJf0nXYrCU+PB4towMDIY258QTa2FP 5ZxhTxHSzbiRDYVC30rFa1hze6rpmfDQj5WpwfAzUYwyzeKl1EguFT3C/LWd8KLQ4NJn0+ej mPA42n9RBodMbS32TeDt36hmOLLtSf6Q54JUq218OZwh1+ezXBVDwcZPXO5q/Skjk+1W/pEN lcZvCEpqMAPGFeDF4enGUfi+Tjd40BaC4E4//AGBB+lyo3Z4z6DAkE9UBlaaY0Li8txSTYvy Qrc9z/2PgBHvLqQQHOb076bqzKuJCQYRVM/iT84oRgtuIe6/txq5v7bZpM6SfPu0IWpcd3l6 2nS9HBWulkFsSIcO0xXF3jjiinkmJXGRxVdCu7/DjP8tVMRiGJIiuWVBbnnARRocNnxorqp5 iFsdy2iAAYmV8zleMulGrVlIV1Rz6zZWAAweHY2d3Xbyxyj+mS4Yadb6yxkKUFiP64sIGGyP hGO51kKv84OZhNGiJObharrVqzGKoC6RbzYug38NIISMvCdiifblM2RWaJg9z+0yxV9+U3OE ZyabdytHR4n5VdPl1KLqxMm+eZznEgWnDqLLbiilkjP+efONRa9FOZeWHPTP79R0U9xiFiMm zqpH5DRkEs3vSyXSnS/zLP/2nhWdyVmXs6v9JQMHgNBSyI/cFwc5zbq6epJU6RunrhPl/eO+ Xe4W0RCz0H4i2GBIgKPAk2Popu2Av6TdFo3Yn4hO0iGwX8mbdr95asTbcJvL7Im6PZi3bh/S PxcI5eMBfFGSzLm/TUBbMai8Nw+JUrz3Q/ebTC4ZDUffoJ7Q1Cb8NHTYQaypjIFCTC6tJVir uT4hB/bW5cKWy9rEN3SNKC011q0sHVEwLByUkLEL8N9YkLp9IQ2eSX9guVue5MHKAnZxyvc3 AGTWE9Kqe7Iqo4z0d/ImaHb8Nv5T7ogRhJXRjCJ46y3OC/W+nuY7bVBCOvYLyrAUG7U+bm5Y bkHxf/LL/Bazk1BtJBxEug3wPtmtcfvvbJT0i9tAG7PMwawErplL3SLgZtPu6lKyuMLsAe6Q BvSqNxTOLHPM8L5Cl8BYgEia73bh/0TnzDT69UzIVn7u3ArrObWDx0KMknekjFZIZt0LJghk LUot8Mh4gCijgYnb4SdhSdO+mXQdnENXs3LbH3B7FMHXubz9mx/XA==
  • Ironport-hdrordr: A9a23:4RGFca60ERKCI8O+mgPXwVOBI+orL9Y04lQ7vn2ZFiY7TiXIra yTdaoguCMc6AxxZJkh8erwX5VoZUmsj6KdgLNhRotKOTOJhILGFvAB0WKP+UyEJ8S6zJ8h6U 4CSdkBNDSTNykCsS+S2mDReLxBsbr3gZxAx92ut0uFJTsaFJ2IhD0JbDpzfHcGIDWvUvECZe ahD4d81nCdkTN9VLXPOlA1G8z44/HbnpPvZhALQzYh9Qm1lDutrJr3CQKR0BsyWy5Ghe5Kyx mIryXJooGY992rwB7V0GHeq7xQhdva09NGQOiBkNIcJDnAghuhIK5hR7qBljYop/zH0idmrP D85zMbe+hj4XLYeW+45TPrxgnbyT4rr0TvzFeJ6EGT6PDRdXYfMY5slIhZehzW5w4Lp9dnyp 9G2Gqfqt5+EQ7AtD6V3amIazha0m6P5VYym+8aiHJSFaEEbqVKkIAZ9ERJVL8dASPB7pw9Gu UGNrCT2B9vSyLYU5nlhBgs/DT1NU5DWytuA3Jy9fB96gIm3EyQlCAjtYgidnRpzuNKd3AL3Z WCDk1SrsA8ciYhV9MLOA4we7rGNoXze2O/DIuzGyWuKEhVAQOHl3bIiI9FkN1CPqZ4iqcPpA ==
  • Ironport-sdr: Vgv/JxTyg6ABL1VNe0/1+zxqrCWK1vbDo/8lVPVpZTJZN2apbLMByXP79Frzf0T3+mU6ZST5x6 jO0XtQQnLmMkFUGndGOtLbg+pHCrTiwgsMMCcuJHW+A1RZlJiEV4wQ5I5OqNSzHcU09L6JOexp hX7mStJ68QmAWKmcc9b9X4vhwj0+ok2Wd5Dhj9iUMenEA7W3q6WK0UfoINl/eysCmY+ZLtUrCf O6fHKzGeliNSynKvis9jSGNJexkAlngdb11igFQQZBik3lyYOGNad1d7G6NXZttKd+naLYWi5H 9lgZi13hN+ozEVcg2McluQC3
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Fri, Nov 12, 2021 at 10:48:43AM +0100, Jan Beulich wrote:
> While domain_context_mapping() invokes domain_context_unmap() in a sub-
> case of handling DEV_TYPE_PCI when encountering an error, thus avoiding
> a leak, individual calls to domain_context_mapping_one() aren't
> similarly covered. Such a leak might persist until domain destruction.
> Leverage that these cases can be recognized by pdev being non-NULL.

Would it help to place the domid cleanup in domain_context_unmap_one,
as that would then cover calls from domain_context_unmap and the
failure path in domain_context_mapping_one.

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.