[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen: don't continue xenstore initialization in case of errors
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 15 Nov 2021 11:08:22 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b5jtFWyJbg3cqw/Q+xikBVTcUFSXwfvaXTrrJN9N3TM=; b=Fcy+4RBBoUJeo5SWP8SFLOgy6fUWQ1WNQxtnWf0gd0DpAliFgPeqfYh+vSf8F/l/cN1LhVXJjdiDHwxtyKCI9O18eMjFEZ8ALQb7WyzdTC6xo76ClMKtYMwP+wS5I+Yei5DWkbXDkH376ZK8cXAEaObIn90V1d3wDBNL2aRHSV2R8U1PmbwPx2Yf2egboTyqVgPy0GlF7Xoy/jgQnrYvWDPRA2btLfNj+lLBtqH195TfHfm5WSRkMNW7zOms94fw1hfvBEPHYygJ4N3yhE1DTi8N5BZbNwiw79eJ7korz5FJZWrb0osuU0LkuxlXhyq9USfZ5fCaLSlzVvPGbgLNsQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S90I3Nh5Ftz5MFKTgiDKR/nkG3VaHNlE8j+4HMyuyqcvQAVdpsBhIuySjuPPykei9LKNoO2Cq6h7d926v38R/ir+QhZbqzKIoLVpcLQT77s2S7I/4wIqyRDM0Vu/LjCqLiQMsMVWX5FZyGwI2PVrI/GFeZau4VGuO9sYiON/LTjGBGbOjdGDeCW9y/3+9g2CEYRguLVBk863XcPZpxqPldEx2nFTIMgz4tP698L3XsTKynyUx20b+YR5AXWV/P6ljTcGCHssSYMyc/qxqFXlukApyKD9pma7W8SbBA/zplIKHL2O4LW7iMqwYzfyQ6E6O0kpPhVqGCBH2iteemvXvw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: boris.ostrovsky@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>, Stable@xxxxxxxxxxxxxxx, jgross@xxxxxxxx
- Delivery-date: Mon, 15 Nov 2021 10:08:34 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 12.11.2021 22:47, Stefano Stabellini wrote:
> --- a/drivers/xen/xenbus/xenbus_probe.c
> +++ b/drivers/xen/xenbus/xenbus_probe.c
> @@ -983,8 +983,10 @@ static int __init xenbus_init(void)
> */
> proc_create_mount_point("xen");
> #endif
> + return err;
Personally I think such cases would better be "return 0". With
that done here, err's initializer could (imo should) then also
be dropped.
Jan
> out_error:
> + xen_store_domain_type = XS_UNKNOWN;
> return err;
> }
>
>
|
