[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH-4.16 v2] xen/efi: Fix Grub2 boot on arm64
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>
- From: Luca Fancellu <luca.fancellu@xxxxxxx>
- Date: Tue, 16 Nov 2021 08:36:57 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RxsdjH3NFxHT7NWiAQAjoIjnC7yeAsItOP6mJN4SgaI=; b=J0sWd15Nnss1rLA9I7vhdjeIELR9QBpJ6W7/FM9wEeHbGSqpW0q5llQUaeWomZHjDXkzch+u+wwOYUU2PFwQYmxVCzmAyG7o5I+aX581ZGXJCwpjpeMc2yJyELRHvdyNMqznpI4PKrhScCBEhpY3TzS4CbNwCaaxDWzSWCBgAlwutS9ubTrMVckrdRscnGq+IMOkt7jeKHJo13DEuzVn7vgAA/szdomBD/gIrb5O8Y5uLHZF34tFzE0Lb5IV1oMEKVMJBgWOIxAzk8nMwmvxqDxnQD8WP8B5oCLakdViUUrOH+baKvGrmYzT/H47JYk/uePJ12VPku+d1Vq/2hfTnw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LGkfrjSXXm9eYfk2xdm/DVOj4wnxJySKunz/18u+6mC03Es9t3AJMHCCYykn29c3pt5ILW7K6KlLx8fZ7JvE3mS/BSRtrOZbrHrFJlwZDHAv86VF1mRZKmKZ3e9hi3mchI3KnwsPzid6CHV+OGD66V/rhe//+UHrDi/TZmvgSZxub+Ivk/mrjuqRfEbCOt3/vhzUB+THlcke7KzPO1vyMAOwMWHzB1wwTqmJrEvFV8qG0UdEHA0+eR3KEM8W3Ngvwuf35mTgySsVlWSSR8fyfymfFwBzrxdEfgl4zLb/M41e2X1hOIRflR1yiR9TBMgOrmihm5BBekFwHvRR6Fd/zQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, wei.chen@xxxxxxx, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 16 Nov 2021 08:37:40 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
> On 15 Nov 2021, at 22:00, Stefano Stabellini <sstabellini@xxxxxxxxxx> wrote:
>
> +Ian
>
> On Mon, 15 Nov 2021, Julien Grall wrote:
>> Hi Luca,
>>
>> On 10/11/2021 14:02, Luca Fancellu wrote:
>>>
>>>
>>>> On 10 Nov 2021, at 13:36, Julien Grall <julien@xxxxxxx> wrote:
>>>>
>>>> Hi Luca,
>>>>
>>>> On 10/11/2021 13:05, Luca Fancellu wrote:
>>>>> I thought having the EFI_FILE_HANDLE global in efi-boot.h was a “no go”,
>>>>> but if it’s not then instead of
>>>>> calling get_parent_handle in efi_check_dt_boot (that is the main issue
>>>>> with EDK2+Grub2), we can do
>>>>> something like this:
>>>>
>>>> fs_dir_handle is only used by callees of efi_check_boot_dt_boot(). So the
>>>> global variable is not an option for me because the risk is not worth it
>>>> (it is easy to misuse a global variable).
>>>>
>>>> Instead, I think fs_dir_handle should be an argument of
>>>> allocate_module_file() and propagated up to the first call in
>>>> efi_check_dt_boot().
>>>>
>>>
>>> Yes you are right, changing the interface of handle_dom0less_domain_node,
>>> handle_module_node, allocate_module_file to host also an argument
>>> EFI_FILE_HANDLE *dir_handle
>>> avoids the use of the global, then the handle is requested in
>>> allocate_module_file only once and closed in efi_check_dt_boot only if it’s
>>> not null.
>>
>> That would indeed be better. I'd like this patch to be merged in 4.16. Would
>> you be able to send a new version in the next couple of days?
>
> I'd love that too; adding Ian so that he is aware.
Hi, yes I will prepare it and push very soon.
Cheers,
Luca
|
