[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/5] x86/Swiotlb: Add Swiotlb bounce buffer remap function for HV IVM



The subject is wrong, nothing x86-specific here.  Please use
"swiotlb: " as the prefix

> + * @vaddr:   The vaddr of the swiotlb memory pool. The swiotlb
> + *           memory pool may be remapped in the memory encrypted case and 
> store

Please avoid the overly long line.

> +     /*
> +      * With swiotlb_unencrypted_base setting, swiotlb bounce buffer will
> +      * be remapped in the swiotlb_update_mem_attributes() and return here
> +      * directly.
> +      */

I'd word this as:

        /*
         * If swiotlb_unencrypted_base is set, the bounce buffer memory will
         * be remapped and cleared in swiotlb_update_mem_attributes.
         */
> +     ret = swiotlb_init_io_tlb_mem(mem, __pa(tlb), nslabs, false);
> +     if (ret) {
> +             memblock_free(mem->slots, alloc_size);
> +             return ret;
> +     }

With the latest update swiotlb_init_io_tlb_mem will always return 0,
so no need for the return value change or error handling here.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.