[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/5] xen/xsm: Address hypercall ABI problems
- To: Andrew Cooper <amc96@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 18 Nov 2021 14:01:10 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sMHiOjAx7W5b5fB++qkpqRKDBkTMzGM+MytiDHkCVGA=; b=bqS4Xgh+od4a6QQpRI/twUA3wXqp6ggAorCenH6zQjfcaVhtShkL9i7ra14YiRv9ddCiITNMI/NaBhyJc9P4uOfoRoOn6rWC2ALHgkCUL4zCFwEKf76JA5O95iYA3oQus9WOAEccik4GHrFgk/osGEtCCUL5SObUros53QWZ+3iRpTx0ulF171X2Ql+txtBSTK4Ti/e0NjlGdZzip+FSLRp3BVKmtAQxywliF/vKtoOLTYypWwtFbtyD2iYEwg6P6uKQ/srnEzMfbRSmMjEdjO1LH1w0U+C4Fnbo+VL+NDLu5egxMuRYSTkPTMyJHJ1DjwILwL4vwtMPsGSbB+rBdQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HWUEMhyWYFKldhh0eftUmSDAYT6bP1fkWIgka2uU3A7+kKUj12m/cvhi7SdDOSNpVgJi7n6IBTduaFlFQiM6opKIyika84z1V42vyu1iFGwdkCs4nTXmDNrqXKnXJU6qpFhMMUQXWFFz01D7oUj2/IP1NAnAejdsJEqEwSpd33IA7X5OaGhDOPtMyDXCb3I4KEbFM6bM6Vvkb6Tp8jVDsqH46vtWZVV/k/ifiYzsyf1eJwz0c2HO1M+xDII+8PMdMby9AWbgDy7FwZHhmbOWugUeBJSrLpVCNjT3cNa8R6PD4wVCDCaqCzijEpZ1id5e92W3LHEoe1mMopvBEZA2ow==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>, Daniel Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 18 Nov 2021 13:01:23 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 18.11.2021 00:20, Andrew Cooper wrote:
> On 17/11/2021 23:14, Andrew Cooper wrote:
>> On 08/11/2021 09:50, Jan Beulich wrote:
>>> On 05.11.2021 14:55, Andrew Cooper wrote:
>>>> --- a/xen/xsm/flask/flask_op.c
>>>> +++ b/xen/xsm/flask/flask_op.c
>>>> @@ -22,6 +22,8 @@
>>>> #include <objsec.h>
>>>> #include <conditional.h>
>>>> +#include "../private.h"
>>> Kind of odd: I'd expect a file named such to not get included
>>> across directory levels, unless a single component was split in
>>> such a way (to me Flask and XSM core are separate, yet still
>>> related components).
>>
>> Its all a tangled mess because logically separating XSM and Flask was
>> a task done when SILO was introduced.
>>
>> There is not an appropriately located file (under xen/xsm/ ) where the
>> prototypes could reasonably live, and this felt like the lesser of the
>> available evils.
>
> I guess it is worth adding, so we're all on the same page.
>
> The thing I actually need to do is fix the fact that the prototypes for
> {do,compat}_flask_op() are local in xen/xsm/flask/hooks.c and not in a
> header shared with xen/xsm/flask/flask_op.c.
And I fully agree we need to do so. Me saying "kind of odd" also wasn't
meant as an objection, just to express my surprise to see something like
this.
Jan
|
