[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 06/11] vpci/header: handle p2m range sets per BAR
- To: Oleksandr Andrushchenko <andr2000@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 19 Nov 2021 14:16:47 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HBWMlAbJXX8nB3i1kv6nCtJbzI2EMPzyOPUbQf45WWU=; b=inTnNbsz0S7UIHjepdf+I1jyqz7mwgnDHlK7L00SMPjdNDv5yJYDUxod0EYbnzsgjiDzDiJYcc2arECIpuOKSeTAHf7nbtOEbklyZB340Irj3DNgxB6IGisenw2OPnhkTsXqKXTJ+GZXxgDXlMna/aMHpKCGslmLTkolAwP0CZE4rhDqtY6sZqrjHwbP31vlgrMXG5wMDRE3bjJO5CLAx1OMqqHfkLR3zSSrGR1a2bNhyH0HQwyB0bpjYxA7NTslp5JJdvKpsAw2HwtQ+YZwWyD8O2PL+cPyZVc1a8ydl6Z/2xpITMSqgmkZFUa4cjJhHcBIpbZ4QJb7KPCsTVilyQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VBknChNIYyG9tAHezXaL55IJEiK9VKie5f4sPDxWi0fUlvtPb8igwslDuP0Y7NWPEcnRrpE5K9UImgI3ambp/blWf7qhu7b9s10yXM3p4qg3Ch/vAzRjKtDgaj/CgMtTI2WvEACfIwNFJwoYwdmeleADVvMNaveSpPyO2YyPExr1FN+mnKhozoOy9mMSgJHGhZZm6iM5SmTi75vwO69OZ1jnfertPVsS/mmOw41EaDs/RZaRpLg+mHcjgiy91KkXR8oy03e0FW203dhW2//88ikOwG6+Udyb3tp6K+xMWBNf+p50gwSvy0rPsQ1aJWgyjeWlalH3qNT+wHUiWnHhIw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: julien@xxxxxxx, sstabellini@xxxxxxxxxx, oleksandr_tyshchenko@xxxxxxxx, volodymyr_babchuk@xxxxxxxx, Artem_Mygaiev@xxxxxxxx, roger.pau@xxxxxxxxxx, andrew.cooper3@xxxxxxxxxx, george.dunlap@xxxxxxxxxx, paul@xxxxxxx, bertrand.marquis@xxxxxxx, rahul.singh@xxxxxxx, Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 19 Nov 2021 13:17:26 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 05.11.2021 07:56, Oleksandr Andrushchenko wrote:
> @@ -95,10 +102,25 @@ int vpci_add_handlers(struct pci_dev *pdev)
> INIT_LIST_HEAD(&pdev->vpci->handlers);
> spin_lock_init(&pdev->vpci->lock);
>
> + header = &pdev->vpci->header;
> + for ( i = 0; i < ARRAY_SIZE(header->bars); i++ )
> + {
> + struct vpci_bar *bar = &header->bars[i];
> +
> + bar->mem = rangeset_new(NULL, NULL, 0);
I don't recall why an anonymous range set was chosen back at the time
when vPCI was first implemented, but I think this needs to be changed
now that DomU-s get supported. Whether you do so right here or in a
prereq patch is secondary to me. It may be desirable to exclude them
from rangeset_domain_printk() (which would likely require a new
RANGESETF_* flag), but I think such resources should be associated
with their domains.
Jan
|
