[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/7] (mainly) xz imports from Linux
- To: Ian Jackson <iwj@xxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 22 Nov 2021 08:10:17 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HdHcSsr8xwWxvSz1xnhn7H8HJUtphqQGBcmkiCpbgxM=; b=RseO/oT4LQdtn0zPuwKB/WAmPfDXZXPyniL/HCwS8R6nTs9HRBtmQY9MrfmGI8PA5tmAKUGhS9/fTBUPByYV0Fi+R0fGtrkF1pxDJK7TVo4RVs3KgHDMQyOxZAMJic4c/wJ1EXbDzc934kjtUIsr8gSyK2Ahg8n5FqHcSuHtl8qBLld6kQWWtdGw948L7L/Wrk/A6V2X5B9wKPt5fLlk/4bupASdyLH6/4zFiElLrNvvie8ScO492bS6CCKdX3GtXJp1IFl6AnfF+Y4qa3aYYDh4Fq1DOQNWNE4cl+52voOgoTDcCvlTP/JKBnCWH+TGI3LrkW/wLbiRsThjeSLJmg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TmApmlqg2RXDDaACtQMdFv29E4WAMwAvZ8Fls9VxPEzk4sogwa968p77tFO/EYroLq0hOq0AwQKnsXiSChhCdJPUBh3DACQ0lOkg04TiLTm2xiApKMq2AQ24KErgMpYg1meHTARzsJVsP1DdP6I2DBelDi3Q+Ea65t9hdAXnDFr8C/VN3LD11qn+WbFK33oMLTFEbaGS+kQBi4ZxSb6orQBzYTJG2Lw2NnmDjAhUv01x8zMze5tBzsBkLMG4zIekDa9ARDzM+ShP9cbNYd+7NQ9uAFVEYtF0eYmnxdQyeT2+NARl7dv28ebzmrkTtffrAyjSWKBZxMbmCHJV4WWp9g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Mon, 22 Nov 2021 07:10:42 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19.11.2021 15:25, Ian Jackson wrote:
> Jan Beulich writes ("[PATCH 0/7] (mainly) xz imports from Linux"):
>> While going through their 5.15.3 log I did notice two changes, which made
>> me go check what else we might be missing. The series here is the result.
>> Linux has also updated zstd, but that includes a pretty large change which
>> I'm not ready to deal with right now. Them moving closer to the upstream
>> zstd sources is certainly a good thing, so I suppose sooner or later we
>> will want to follow them in doing so.
>>
>> 1: xz: add fall-through comments to a switch statement
>> 2: xz: fix XZ_DYNALLOC to avoid useless memory reallocations
>> 3: decompressors: fix spelling mistakes
>> 4: xz: avoid overlapping memcpy() with invalid input with in-place
>> decompression
>> 5: xz: fix spelling in comments
>> 6: xz: move s->lzma.len = 0 initialization to lzma_reset()
>> 7: xz: validate the value before assigning it to an enum variable
>
> FTAOD I think none of these are critical bug fixes for 4.16.
> Please let me know if I'm wrong.
Indeed, you're not wrong, and I intentionally didn't tag them that way. All
I wanted is to get them out rather than sit on them.
> In theory 4 is UB but in practice the result is presumably just wrong
> answers.
Like Linux did, the plan is to backport that and perhaps 7. But there's no
urgency.
Jan
|
