[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/5] x86/traps: Drop dummy_nmi_callback()
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 22 Nov 2021 09:51:16 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zi7GBd2KgxU0iOVPiuwxSI/ci+UPVqYQyZX14nPLrcM=; b=YyyD49LLto4dXKefQlyTe+v6q022RroyXnVW4aYo89KlqpTY/j0pYjxRq1JqDJXXlco223kfKhGjfuDDYU11p11nN7zKNF5fUqLg1YY3a8nJaz92xGgkmiP3IX+GvqDbFROuYz094ezP94euqzGmehdljPaKTotPkzZWym6pbeBz4zYkQyasjdd6h1aMJESsgszzP+9l8rs2+H88GITiVgVrc6PjkKlatYw3gWLzaUKkHvvHCjkcN1JwOJd+YJMVmZfcXk7d7PIalT1kInH+z3wtCWSIpMyI9KsA0+xJrieRG2bVgmCxe1m51NSGzIJ1q8a/j41Chg8beufPEVVMXg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KnKa/lsi1kh7iUPtWtG6P2GE5NSz6R1qUUQISJeSBmJY0XD80MEsfV/XI51djPooQC7f4YlzZXg+58NvSpBwUTCS7T9lcCmH09PrLnUf5BdMT4vvOR8D1vWd+G+iR+UdnV6AK+naO99eAUMk0mi9ceabQKMA7cO15UuHW6mee5K23fsf+HRIIriR49SGBWfDRDUzveS0Z72LeihAGCxotdYkyVd9MrSQER5hLBU2ZXQ3kMtV4FLblkSedUlsAhYxiSu6TQVCyzsz4Gj1i2EPXHYb6IoUUUPMTOmWKKswZ0yJYl3M/hCmtCZsS2j7uuxFWuEtsWLEv3SGnCZqwqEIPQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 22 Nov 2021 08:51:32 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19.11.2021 19:21, Andrew Cooper wrote:
> The unconditional nmi_callback() call in do_nmi() calls dummy_nmi_callback()
> in all cases other than for a few specific and rare tasks (alternative
> patching, microcode loading, etc).
>
> Indirect calls are expensive under retpoline, so rearrange the logic to use
> NULL as the default, and skip the call entirely in the common case.
>
> While rearranging the code, fold the exit paths.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
|
