[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH RFC 1/4] xen: add a domain unique id to each domain


  • To: Juergen Gross <jgross@xxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 22 Nov 2021 11:01:44 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d5WpBCEohQbPxxyYGbSVptHk8uzl3xXdjzUWdcobwFA=; b=CYuu6kpPr1Fg5ZRctACt35U3nJKzDeA349KDksdIuBzBArMWfvDwj5cv+vt+Z7SBqiljmdFZYYfTXDEF5sLgUAxrqEVB0t+OtoO3AIZcgTw1PNxJUrPWc7/VSb/giMD6slY5Xjl2zq+QC8El0zTPxV1NJ57UmT1JZiIymp6glAtcDD45lCGQhZPH/CXsE+DbDwEqZEXkELgkgXQEn9mw9p6P5UUiyB28MXgVE8S1UfCaYABvRLE6Ek+7HB/2ZbfG07mSh6oNUPQ9wgGSg58SrdhY0MwEor+hMvPbO3FOkhR7NnqEZXYmoinD/64FDWoORUUdappNtHKl7LgySiVhMA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ehiu9dDRlxZFkfWRzkyWXAvjxet6rNInsdWDorXPlL2osBrPzPfXXbD1LOiwfQiDZGJ2rr2tsqIvL2hHMmd6CR9TiLw3Efx0mPlOF79gDiYQdLbGSzb8271bIOXxmeVAQIbUagpIC0pyP9m8/XpA5Jrowl7IhJI1m3n0T9ioc9+oKQN2nyFJ4zWRByuRt1S3XGj3BWi3BJyNEHQ4B3QDXCZTD84b0/wzZv2MZKn67G7PZfenGplkGExwzFO98VDj506ehxWT6jUy8JCnezBTLSwx6hy8rqPfWSIXpUwe58nb0k6sI9Oi3ikucdEtxgQLcIJfZnpBq0v9it3+RmulXA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Mon, 22 Nov 2021 10:02:19 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 14.09.2021 14:35, Juergen Gross wrote:
> --- a/xen/common/domain.c
> +++ b/xen/common/domain.c
> @@ -84,6 +84,9 @@ vcpu_info_t dummy_vcpu_info;
>  
>  bool __read_mostly vmtrace_available;
>  
> +/* Unique domain identifier, protected by domctl lock. */
> +static uint64_t unique_id;

Unless a reason was given for this to live here, I think it wants to move ...

> @@ -473,6 +476,18 @@ static void _domain_destroy(struct domain *d)
>      free_domain_struct(d);
>  }
>  
> +static uint64_t get_unique_id(void)
> +{

... here. Then
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.