[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] vpci: use named rangeset for BARs


  • To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Mon, 22 Nov 2021 11:53:22 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XgojSifz+Dxy5dmpQDWrcVCvVJk+JWpdGITHIcC8Vj0=; b=aX+9RAD0rxIvXhEXyF8JdYp5P2lfiHqMF0PRKqgD52c26pmaAXAOlRwlrTpWGCGLKqAp+jPRlEOcWhUhuWIeIn0nxOalGqA0biSawplD4LkCqjzCeLpt16Lqbj9tpdc0egu/Ubiv4IYbZqdXW+QEAGbtXE7otR1BdOdA4i2Z0utITXsqJsM70WsxoQnSpXGAaUg+ITn2lU0IMzvJC6vUxZn3LDtYxPMUmwZPBUmO2JjtCTp2n6pmjoYSE1QbHHh7j4V+SUoknUDmTQACKLZk4wFQPvjsQT3ToZJdg1t8xPcrqyzGAv+ztHRhwAwI1lxr9CZ32C4CU3WtGZ0fKkmieA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aNFXfYre0J9W2i2xi7u7x/aV6NNG7KeMUSTy59Z3CBXnbChXP8kHGzrUTBztRrJ7MhqmjinkrXl0sNDRmdgpukph8gt3KnFVntt4iT2SvJLX7Yi7zlIjinFHIMwG+ZN+iHFkJak1bbZSnMqiekSv/pXHlvtPIQrliqOQ84maR8BBSebACi6/w/2r24sOjoRAlVCC+hGFSbcdC2serFCvifa/rZI+AmdiCjb7MKkEEO6Rez8pptB0hjzYdUZhOMRDu+e4wXneAxKhpEYs/nFbpCa0ic5GX/lj90r9Q3UzsKdsoQTKiSZfX04phX8OmA2Nnc4uYOAaU8HsDdMKkiwJyA==
  • Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Mon, 22 Nov 2021 10:53:45 +0000
  • Ironport-data: A9a23:qqs78ajJSR1vJJJCni6r/fNAX161gRcKZh0ujC45NGQN5FlHY01je htvWWnVOPvZY2T0L94gaYux805SvJDTnd83HAE5/nxgQikb9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0F0/NtTo5w7Rg29cy24Dga++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /0droyJFgR2IpbSxr4CeTVyKBNlL4NJreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr KJCbmpXN1ba2rzwkOnTpupE36zPKOHxO4wSoDd4xCzxBvc6W5HTBa7N4Le02R9t1psQQqyHN 6L1bxJ2Nj/mcixRHm4ICbI5n/+2jWLEKBRh/Qf9Sa0fvDGIkV0ZPKLWGMrYfJmGSNtYmm6cp 3na5CLpDxcCLtudxDGZtHW2iYfnnyn2RYYTH72Q7eNxjRuYwWl7IDoSWFigqP+1kHmXXd5FN lcU8Sojq6s13EGzR9y7VBq9yENopTZFBYAWSbdjrljQlOyEuG51G1ToUBYRc8wf68xpWQc0i AWWtf/DPg50opOaHCf1GqivkRu+Pi0cLGknbCACTBcY79SLnLzfni4jXf44Tvfr04Sd9SXYh mnT8XNg3+l7Ydsjjv3jpTj6bySQSo8lp+LfziHeRSqb4wxwf+ZJjKT4uAGAvZ6swGt0J2RtX UToeeDDtIji7rnXzURhpdnh+5nzuZ643MX02wIHInXY323FF4SfVY5R+ipiA0xiL9wJfzTkC GeK51gOucULYCH2N/IvC25UNyjN5fK+fekJq9iONoYeCnSPXFHvEN5Sib64gDm2zRlEfVAXM paHa8e8ZUv2+ow8pAdas9w1iOdxrghnnDu7bcmik3yPjOrPDFbIGOxtGAbfMYgEAFas/Vy9H yB3bJDRlX2ykYTWP0HqzGLkBQxQcCVgW8mp85c/myzqClMOJVzNwsT5mNsJU4dkg75UhqHP+ HS8UVVf013xmTvMLgDiV5ypQOqHsU9XoS1pMCoyE0yv3nR/M4+j4L1GL8k8fKU99fwlxvlxF qFXd8KFC/VJazLG5zVCMsWt8N08LEym1VCUIi6oQDkjZJo8FQbHzcDpI1n0/y4UAyvp6cZn+ ++81hnWSIYoThh5CJqEc+qmyl685CBPmO97U0bSDMNUfUHgrNpjJyDr16dlKMAQMxTTgDCd0 l/OUxsfoODMpa4z8cXI2v/Y/9v4TbMmExMDTWfB7LuwOS3LxUaZwNdNALSSYDTQdGLo46H+N +9b+O7xba8cl1FQvosiT7sylfAi58HirqNxxxh/GCmZdEyiD75tLyXU3cRLsaERlLZVtRHvB xCK89hef76IJNnkABgaIw98NraP0vQdmz/z6/UpIRqluH8rreTfCUgCbQORjCF9LaduNNJ3y Ogsj8ca9gijh0d4Kd2BlC1VqzyBI3Fov3/LbX3G7FsHUjYW92w=
  • Ironport-hdrordr: A9a23:c+3YfqEF6YHLCatipLqFcpHXdLJyesId70hD6qkvc3Nom52j+/ xGws536faVslcssHFJo6HmBEClewKnyXcT2/htAV7CZnichILMFu9fBOTZsl/d8kHFh4tgPO JbAtRD4b7LfClHZKTBkXCF+r8bqbHtmsDY5pav854ud3ATV0gJ1XYGNu/xKDwReOApP+tcKH LKjfA32AZINE5nJPiTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1SvV Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfpWoCoZ 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8DLeiP28YAh/J9tKhIpffBecwVEnpstA3K VC2H/cn4ZLDDvb9R6NpuTgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed MeQv003MwmMm9yUkqp/FWGmLeXLzEO91a9Mwc/U/WuonhrdCsT9Tpd+CQd9k1wgq7VBaM0oN gsCZ4Y5o2mePVmGp6VNN1xMvdfNVa9NC4kEFjiaWgPR5t3cE4klfbMkcEIDaeRCdo18Kc=
  • Ironport-sdr: mutc6gOzyIWodEP8oGyiz/oKYCtIZ4DZTmX5axbw9f6l9AeRO9xiJvfXD3ZERNU+qQCIDyPrY6 VPHyFrskEbkaC2DuLH/lyaySGXCrNDxP8e7Rh5bPnSDbuT1MVoMz25j9K3a4QP8cCaXKSx0ETr b7tI03dtnmKvXRIoOpP0W5EKmvZQ4onlBS3YZi3sXAwxoRW6mTZYZVw3MArkMpKg0QzWcC6JY1 E4dV//pkHsAZL6+fpN9HeGTGVH9epgEHo6bNcG0QvB/ObK8lylIFHi5E0lBPFvSo9F5vOYFtvt L3Scs30lZiGr8TGS9R4igM+g
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Mon, Nov 22, 2021 at 10:50:18AM +0000, Oleksandr Andrushchenko wrote:
> 
> 
> On 22.11.21 12:43, Jan Beulich wrote:
> > On 22.11.2021 11:27, Roger Pau Monné wrote:
> >> On Mon, Nov 22, 2021 at 11:28:25AM +0200, Oleksandr Andrushchenko wrote:
> >>> --- a/xen/drivers/vpci/header.c
> >>> +++ b/xen/drivers/vpci/header.c
> >>> @@ -206,12 +206,16 @@ static void defer_map(struct domain *d, struct 
> >>> pci_dev *pdev,
> >>>   static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool 
> >>> rom_only)
> >>>   {
> >>>       struct vpci_header *header = &pdev->vpci->header;
> >>> -    struct rangeset *mem = rangeset_new(NULL, NULL, 0);
> >>> +    struct rangeset *mem;
> >>> +    char str[32];
> >>>       struct pci_dev *tmp, *dev = NULL;
> >>>       const struct vpci_msix *msix = pdev->vpci->msix;
> >>>       unsigned int i;
> >>>       int rc;
> >>>   
> >>> +    snprintf(str, sizeof(str), "%pp", &pdev->sbdf);
> >>> +    mem = rangeset_new(NULL, str, RANGESETF_no_print);
> >> You are still not adding the rangeset to the domain list, as the first
> >> parameter passed here in NULL instead of a domain struct.
> >>
> >> Given the current short living of the rangesets I'm not sure it makes
> >> much sense to link them to the domain ATM, but I guess this is kind of
> >> a preparatory change as other patches you have will have the
> >> rangesets permanent as long as the device is assigned to a domain.
> >>
> >> Likely the above reasoning (or the appropriate one) should be added to
> >> the commit message.
> If I fold then there is no reason to add the comment, right?

I find detailed log messages never hurt, so in the patch where you
squash the chunk below I would add that as part of making the
rangesets permanent they are also linked to the domain struct in order
to properly track them.

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.