[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 10/11] vpci: add initial support for virtual PCI bus topology


  • To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
  • Date: Wed, 24 Nov 2021 12:43:01 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N7CrNLBJcWpdz23VcauZEF/pG8wXvclqtHNAiT3FZ0E=; b=CQg/PBa3ujQyIwldk8gTBzYoiL+pM0p40by76pOOFOMyzrVqr9jwR1i2noMKjJn3/rAyGqwRtE6OmRUq8s1ACHbsjn5xqBf63U6yB4/H7lAqiHcfJIdhAm1jYSwEi76EXtOTGSMKTG/EaY1qvAZAh8BpM5y3NlXdMuK6uUXvqvw1FgCmNt+zOu2r/XgOJjx0FEyt/0xEQ7kM6F9pOVetpwY3uIXP0+tgH/e9msqznt6aWTEGB2azHc7cmS+DIa9OHojy18YCMsFq0RbCObtRA0BlUi2A8Ni6X8jcdLT4BKzKIC2eb+0SrfkOIn6phLoRSkqMC+aKEHKPPZmCG2ta9w==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=itAE2mvjKETm+U5948U2MUikKt3qaWcq12dVFY98fNtWd+IeV7hG1lTd1M0lZBYVsK2JBahJLkz9T8iLgsFVNtzc19lbq13VwfczKwMp7tHVpvcLl7pIpWzcCnbpm31J4I29Pgotr2gXRjJB9XV7DNg6urBVpI0CTskINaa7sLfG4c+T7XPNPlUs97HwSVf/0e7Ua84VZdqGWrroj74UrPLClKRvzQT3rBXPRO5+UGxXHCRgA3qoNLORmiTFEHT40foNxF8w78ZV0Jpa9idO0fF6ACpiUi/arf/kJ5erLgz6cGj4IghnFw+uRv/ChLnOXRn7AyxIdipkWidtwv3njA==
  • Cc: Jan Beulich <jbeulich@xxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Artem Mygaiev <Artem_Mygaiev@xxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, "george.dunlap@xxxxxxxxxx" <george.dunlap@xxxxxxxxxx>, "paul@xxxxxxx" <paul@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Wed, 24 Nov 2021 12:43:19 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHX0hJNBZwMmlboFUG58hx6442EAqwJkx2AgAkVfoCAABMSAIAAAc4A
  • Thread-topic: [PATCH v4 10/11] vpci: add initial support for virtual PCI bus topology


On 24.11.21 14:36, Roger Pau Monné wrote:
> On Wed, Nov 24, 2021 at 11:28:18AM +0000, Oleksandr Andrushchenko wrote:
>> Hi, Jan!
>>
>> On 18.11.21 18:45, Jan Beulich wrote:
>>> On 05.11.2021 07:56, Oleksandr Andrushchenko wrote:
>>>> --- a/xen/include/xen/vpci.h
>>>> +++ b/xen/include/xen/vpci.h
>>>> @@ -145,6 +145,10 @@ struct vpci {
>>>>                struct vpci_arch_msix_entry arch;
>>>>            } entries[];
>>>>        } *msix;
>>>> +#ifdef CONFIG_HAS_VPCI_GUEST_SUPPORT
>>>> +    /* Virtual SBDF of the device. */
>>>> +    pci_sbdf_t guest_sbdf;
>>> Would vsbdf perhaps be better in line with things like vpci or vcpu
>>> (as well as with the comment here)?
>> This is the same as guest_addr...
>> @Roger what is your preference here?
> I'm fine with using guest_ here, but the comment should be slightly
> adjusted to s/Virtual/Guest/ IMO. It's already inline with other
> guest_ fields added in the series anyway.
Ok, I will update the comment
>
> Just to confirm, such guest_sbdf is strictly to be used by
> unprivileged domains, dom0 will never get such a virtual PCI bus?
Right, for unprivileged domains domains only
>
> Thanks, Roger.
Thank you,
Oleksandr

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.