[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/7] xz: add fall-through comments to a switch statement


  • To: Julien Grall <julien@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 25 Nov 2021 18:03:32 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OdWm2aBLXEmAIhTbHU9dtDXCDZVzD71TdNALJ9ly6yQ=; b=EbiVWe5OE5UBNdU0cuLB09S8jj0Q0JDAgKRukY6CIjTvuXqNghGwotumSkKe0e24n9yq5BcmwrjksvksxQTARcaryDDBk9zSadIdL+BCQyo8cjVzZsVDyN7ITJGGRt+MRBbNsi68L+oMfG+Tr0Z9mMgL1g8cXKz9NkQfm6oVsywWLG7Qa7AcfJSr4dt0GgURwI2OTpqECEQGnwC+9EOOITd7dLXuIjrREUKgYaXufW68LbBVa+Am25N/RYddJiQrSX/f8Zi9x3elKDhnZmeS+KeJLNKxsGl5v/K6sUr5mztl1LKXQD9LB/fl8GbcOJqqQYaNS5O92wm6AtX3VigkXw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ap4GrvOjgP4SBiAQkwUmZZhjJPSNTKTH8u5k2V+8nchDFbIpezErf/3uZruffQqsXWjg3I8dqYnJCYolr0n6WOhtbXqBxBcX8U2KITlqghGp56z5YRdDtwAas/zCG6XYUKljqpa7bF6fPQSlhrhK/pKtPo8y5t0Rapi40kiM6Xs7fiXwndkVE+agUUty236d47Y9jM8E+Tfyrgc2uy27M93iII5aUkkawhS0KJhzJUWnccIcZMqDEejHNeSa19RFdmq1b9GOpE58nUH9xGSYjmOBIcxXiz5k4ERXig3o9+xves61pXSqAXRssZTm09Y5JzwUSuuQMgXp/b5yF1ZwAg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Thu, 25 Nov 2021 17:03:55 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 25.11.2021 17:54, Julien Grall wrote:
> On 25/11/2021 16:49, Julien Grall wrote:
>> On 19/11/2021 10:21, Jan Beulich wrote:
>>> From: Lasse Collin <lasse.collin@xxxxxxxxxxx>
>>>
>>> It's good style. I was also told that GCC 7 is more strict and might
>>> give a warning when such comments are missing.
>>>
>>> Suggested-by: Andrei Borzenkov <arvidjaar@xxxxxxxxx>
>>> Signed-off-by: Lasse Collin <lasse.collin@xxxxxxxxxxx>
> 
> Actually, any reason why there are some signed-off-by missing?

I often keep the author's, but drop ones which clearly got there only
because of the path a patch has taken through trees. These aren't
relevant imo when pulling over the change; I could as well take the
email submission as my basis, after all, where just the single S-o-b
would be there.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.