[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 04/65] x86/hypercall: Annotate fnptr targets
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 26 Nov 2021 15:21:02 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=77pjzMdYczc+UegnQUEuKJ0tHiIXCOp1OAhlvkjLKoY=; b=JYJG4cHmK3FCfqx4wgsIg9PisLvxhZC93cj+keqcgXcwruaGjlIbhoA2h2x5ALcwpHivc3v8p/OFlrhn++LO9DrQWMU7uz9g6o7mQqdDhex05y2jj/wgw5ZOzecMTWAWQeIIKzMapH8IVow7wUgprqAYicFIcgIHAuG824dFbW5/Qy95B7ZppUO44WVvZwzFUnQgwPFEcCKs8ntmzD63mPP+W+DCAy8UwY/GQypWNk3CcZ120jydlxhZ1z0pmOmjV+vbcaOZPlLSuCqrjcTU85BrIIzi+CaIwsGVnYJoioQUd9Js1tiUZPElF9UX0o7eQ5CjS4Msb6txzmBSt2T28A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kk4JEcljHGBKJu2An6Xk76TLdsb1B4cHjE9GlcTkUk16lpWrU0bLgGzXMlxWLT7VsSApBrbNza4bQiPsZxpULW+LeZrdSSAaP/JcUNhGQdi0OCtTOXTA5d8Kibtxcj3suF+5o4Zo/2ROcHcCNjX7MqypKC8KB5C63Hl67SIxJnN24ycV31PWdazgY8y5sVjuCuyF+Zm8m9adigbpp/Z2iN5ROskQu3QgJ+ZFR+zshsuGb/03ZhnYet2QNAmnzOlAdbOpdW3s0nzKXCA+McBfMfcG5+lwaKCxU/gGO6pvHKvfPFIRNUOY6bneHAmLaHGBR2ce8qgCnDF757uaGX4DSA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 26 Nov 2021 14:21:26 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 26.11.2021 13:33, Andrew Cooper wrote:
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
I understand there's not much to say here, but the title saying just
"annotate" without any context as to the purpose of the annotation
is too little information imo. I guess this then goes for many more
titles in this series.
> --- a/xen/include/xen/hypercall.h
> +++ b/xen/include/xen/hypercall.h
> @@ -18,12 +18,12 @@
> #include <asm/hypercall.h>
> #include <xsm/xsm.h>
>
> -extern long
> +extern long cf_check
> do_sched_op(
> int cmd,
> XEN_GUEST_HANDLE_PARAM(void) arg);
What purpose does the attribute serve on a declaration? On the surface
I would consider it meaningful only on definitions, like e.g. __init.
Jan
|
