[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 30/65] x86/emul: Annotate fnptr targets


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 29 Nov 2021 15:22:23 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dPfwG5bep37VB0qMY26d4FN947iRUIVyCDL6KVrRCMA=; b=liRXls8DlBZiuvG7jiaIW+alYLF4kR6ZpnwyH9QRRgqkoijmYtQwGL+hGZlbirGXrd5KD/D5COD9li3nh5ci0vEJMZqRB4h6eb+zdlgmXwHPHtY4dujP7fFw16BmyFIdKFQWtqbiAA24UhwqEM9wAAYB57UJW0CV8aa8UyrpE1LSaO5B3NoxPrwuMuf9jxtblrfcqMZmOW338cm5p1ZJhPZKtpRUf0ynWBJuedS06wtdyMgSzkFbPFmqnMWAT9lLLV7rAa3e2pPslBBewvLq3mA+LIWn9/WJixFS8ysHj98SSSdXum1j1LZFacun4khJB//DiPYhU8bLKRo5R6523g==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n8kHpprCWFjjrqRNN4LHXKbu4BogCYw85M1KPsKEGcUfzGcRlz/Xuzu5PoML15gyEj1TAd0MX7mUVm/s0o6L14wCmRDPHbNYrAvON2srBvVPO20vsszk7mgyJZ86Tphn8axPeTL/Gy3m0z0yLyPzomSuO+phsvlXLXV6ecpW5dXsS2OfHIfXL82VVgBzPvUZwPmMXXSMSsMnNpmoQ5r5JLLIACFbvJWiavuIbnATGjpq59BD4zNEo4wm/ssZcWAac5f/51zEfWa+91GKeITJbjiq5ynaQ7rVp2ZEQxdRGCa6EtzXpwJmF7n1htb9QrlorUPKVQVl1vHvijx1GzEyNg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Mon, 29 Nov 2021 14:22:37 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 26.11.2021 13:34, Andrew Cooper wrote:
> pv_emul_is_mem_write() only has a single user.

Aiui you mean a single file using it; there I can spot three uses.

>  Having it as a static inline
> is pointless because it can't be inlined to begin with.

As long as it's only used to set function pointer fields, yes.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.