[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fixed an incorrect value
- To: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 30 Nov 2021 08:18:23 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KjXlqqwe38smy/OrV4Wn96gzR6zzZoVPtENYaKdRqd4=; b=k9FcylFxvPuVh/COcQBMHE2o2CdKiSQk/Pt8ZiRXcTti6mHlGQ3c4i8QSQa8W9QZ+4we0jEmBHZOiTDzt8MQv+09tC7fnyLRE135kixiviIm1QgEG4wi5EizfLi5u+FupySHKLArI401naPb8TX7Sfyx28PuuEy+ve4W5ZrS7PDTgs+r+ihgCI4txqhg5oPSOEgBwl9x4oXWCSm3eXp5SxdIpSSDF825FMv332YkQncWw/INh3dgTRd4ygyKOu6bgrpI1KPOylvB3K/JS8iakyXC/zYxa08+9SxxXbGBLDIOH60Ue1ODqwEy5T6Abyq9db+hvLjslDSC5sOb33nzjQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vx6x/LZgve1qPJjHGNVxE+t0ZOJHe236Ff5l6ee+pcKBajcMyVXoZ/TYhynCQhvQV/9lichI4fTEm9wQJK44FkNH62Qoc84SUFYzkPp1f2EKhqtkSYnNp0ZxBrNRYgxJ5NkoGXJxx65ei7YFopQ9GcJdWzPGMv9J8J3diJn7uRQanAbEd8VIoAei3PRlLfhlTrfBYeceLzcXhbzaa3LVy0w3N0wjaF5mm+mj1ZMbCCAhUzr4WxPvImb6lwO0QKlZamVxCASUKSxNnt6U+mYh+ung4X5OOTtGcaOpmryS3Njh1wlZnuan33xjuaMFJEVZXIotIKd8IxsI6Fr9yjJuEw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: sstabellini@xxxxxxxxxx, stefanos@xxxxxxxxxx, julien@xxxxxxx, Volodymyr_Babchuk@xxxxxxxx, bertrand.marquis@xxxxxxx, Ayan Kumar Halder <ayankuma@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 30 Nov 2021 07:18:51 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 29.11.2021 20:44, Ayan Kumar Halder wrote:
> GENMASK(30, 21) should be 0x07fe00000
Please can this have a meaningful title? E.g. "bitops: fix incorrect
value in comment"?
> --- a/xen/include/xen/bitops.h
> +++ b/xen/include/xen/bitops.h
> @@ -5,7 +5,7 @@
> /*
> * Create a contiguous bitmask starting at bit position @l and ending at
> * position @h. For example
> - * GENMASK(30, 21) gives us the 32bit vector 0x01fe00000.
> + * GENMASK(30, 21) gives us the 32bit vector 0x07fe00000.
Once at it I think you also want to
- replace the word "vector",
- drop the odd leading 0: The number would better be 8 digits or
16 digits, but not 9.
Jan
|
