[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/8] x86/boot: Drop incorrect mapping at l2_xenmap[0]


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 30 Nov 2021 11:33:09 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GFdkeNfBCQpXbuEIhOTiGCHSN5GB8sLsxSauXc2YVlA=; b=kw6oyIs7NVtzh76Vel/H+vhHmf2pzJz/5cwJLQuCUSqrOF3FMz49KwJJzp56IKQmxA433WlNJs46tMI/PrwotUf+SoBHZQDYeaifs7sQQZ7oHrIuOqy+QIl/zlXbFG8FUGPz67Sfo02t/ErbswtkkrgQBca8zgKjQoHcjC4w6lAjMsTa5l7x5VPo66kJoyarDDjI7zuLcN9N9VIh3VtgUiICfUW0++Hw1v+2wlzUT/c6bJZmHSOgjmJvT3DFs5hn0JfCOL+gdmYhQnkHGmZo91W0r7EoOvzyIhoDHidFcCzh8JAO0lMAp/MI3iQjf0RxUtU3GQsyRwZp+/kEjKvlgw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EKOR66AoWClNtJl4ymFZmS0uZUKFGgCW31qyiW4B5p4ae7wJ6GyvO9R1AXDS9DSuo71taPM7YfTed0PIGZEkIyptBSp/we9zbt6+F0f10KICGQoC3xlote9g/rgZv1zKcOAcWfINIhGAqLAAI4qo96WQ/w4cuLEzAHoAgLJPblcDQKePzj7Fx90s+YPj2Jg7MnLko/aCghwsRp7PVM7+P4ZFo9KdzjnWK0IKtbpg50zCDeUJWgvgqie94Xqxst05rlATPSQlZhZ3diKMP8Brmb0Iw7tZ88n19fLG+TOyon1+W9qwGCFPCWQ0bkoU4N40B75IYtaVi32fu6+cvHNQ7w==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Tue, 30 Nov 2021 10:33:17 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 30.11.2021 11:04, Andrew Cooper wrote:
> It has been 4 years since the default load address changed from 1M to 2M, and
> _stext ceased residing in l2_xenmap[0].  We should not be inserting an unused
> mapping.
> 
> To ensure we don't create mappings accidentally, loop from 0 and obey
> _PAGE_PRESENT on all entries.
> 
> Fixes: 7ed93f3a0dff ("x86: change default load address from 1 MiB to 2 MiB")
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

I guess this may be worth backporting despite not having any immediate
adverse effect.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.