[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/3] x86/vPMU: move vpmu_ops to .init.data



On 29/11/2021 09:11, Jan Beulich wrote:
> Both vendors' code populates all hooks, so there's no need to have any
> NULL checks before invoking the hook functions. With that the only
> remaining uses of the object are in alternative_{,v}call(), i.e. none
> after alternatives patching.
>
> In vpmu_arch_initialise() the check gets replaced by an opt_vpmu_enabled
> one, as I couldn't convince myself that the pre-existing checks would be
> sufficient to cover all possible cases.

Yeah - that sounds safe.  As I said on the previous patch, there is a
massive quantity of clean-up and simplification to do now with
XEN_DOMCTL_CDF_vpmu.

> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.