[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/3] x86/vPMU: Drop supported parameter from the wrmsr path
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 1 Dec 2021 08:49:28 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BGV630vfh15j/xw/z97nBvOgJpDlhqb4jOpQ3HGHa6M=; b=nRCM6u/7nFmGisU4KNM9aeh50WyadGqZS1+x/LggtjRNLD/z6pYrpkjW4XkZwktB4fLlzeZNvT8wXLLy7stbIqLi+l2yzYw+Zc4FNJoZsG8JmaQRQMFuVfbf2y12kJTbYg0hUFL9ulF62ZOZj/yWPMu78HYsm25GMVtnRyv/cWntxUW1Pq9+4a6n2iKhScqdJ+QEPIpNp/9/msoii9DzDSzwCLkJou3NR9hR+iI30ja+0CaxFph20hr4BgpNRvJJ8a6XpBgb/afbwP0XKX9b03cbUrFB+An2uTvgHP8pPz9od7bhQy5GHJWDimjdIskcuxJcVc8P/QJwj9lCask+Lg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VN5Ed2M+u5AZEE/kBhCaSzNGYGSwn0NkrsDqlk6vJnTvzJzPgpf2g4s7Cds+NIMgy17lHOhcP+LWi2XoyazVffidiJf528zUYpyjwk8GDflLcTxyaKaZ/LxYl7FREEsVGHsnyC9iTPFyVjpX8DjOSIxFtDqDMk45vu4CAkIVyaTOyt40PTtu+BX4M+F2StY97/ZFu1199uj0914XJX96iwWBX8Q3Yxx+Ihlybpe6Slbyt2E6BQ93p5p+2U3Ay+8QJbyMaA1xjwMesijeMngasVHtwcl8lOJUxEMqmI4mwSy0JJpLX0TIb4Kx7oAVq+bO2C6+r/alIKGEBtnxVzccTA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 01 Dec 2021 07:49:53 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 30.11.2021 23:01, Andrew Cooper wrote:
> The supported parameter was added in 2d9b91f1aeaa ("VMX/vPMU: fix DebugCtl MSR
> handling"), it laid the groundwork for XSA-269, and in the meantime
> 2a8a8e99feb9 ("x86/vtx: Fix the checking for unknown/invalid MSR_DEBUGCTL
> bits") totally rewrote MSR_DEBUGCTL handling.
>
> Strip out the parameter again.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
albeit please with ...
> @@ -113,14 +111,13 @@ void vpmu_save(struct vcpu *v);
> int vpmu_load(struct vcpu *v, bool_t from_guest);
> void vpmu_dump(struct vcpu *v);
>
> -static inline int vpmu_do_wrmsr(unsigned int msr, uint64_t msr_content,
> - uint64_t supported)
> +static inline int vpmu_do_wrmsr(unsigned int msr, uint64_t msr_content)
> {
> - return vpmu_do_msr(msr, &msr_content, supported, 1);
> + return vpmu_do_msr(msr, &msr_content, 1);
... "true" and ...
> }
> static inline int vpmu_do_rdmsr(unsigned int msr, uint64_t *msr_content)
> {
> - return vpmu_do_msr(msr, msr_content, 0, 0);
> + return vpmu_do_msr(msr, msr_content, 0);
... "false" used respectively, as you're touching this anyway.
Jan
|
