[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] bitops: Fix incorrect value in comment
- To: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Wed, 1 Dec 2021 08:40:07 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wX4hGHg4Q/HE943kglFck1XuUUR0YZyCHmfbkFLWcms=; b=oFQNGwr/OKHt9XKbRVsaeU91NKGgqRPEbTEsL8FSkU5x4Wjno53zhDUUb29ilZNWPFVolvByLTFF/R4OG4TFPDX5RIZRyChO1etMvW8sEj7bb/6wy+FmA8BECPysEODCQDPULRE8tu+cYe68mCEjLSHyVMgp6v6uH7R1qO6CMqkKJLk2nY8yZzIz9YhKcBWFtVtRZLqVm+SHifJRSPJPMWWR+WilzP079rWeViyQaRps4CAYKmhUUH4ByKYC1sM2ADvOWijyJ50zoOAtrNrxty9N4JoMuZpUOnqkweeTPL44nLaVVhvUBmbBWhhgsOexWAskjSHdssM+6s1mkm9wTA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Yr0vUNpoPLgbl3PE6ZvyboDoCoZD1d6JrTwt/K2fTWMZmM8lXPf3h1qaNzEM9tVF68afpkfAtRM4jI60BvGspzbD1B1mLmth6oW9abyFzcU8YnxtkqOZv2S3vE9xgpuuTp0Cg+Au/0+M/6PCGA6Divg8mRcJyzf/mDtx6D/BGtsBXvn//XlsCb3vtR478B6CLHVUxXg7qPMOR5l8YX2suMW+RAP8m4TFAh4kCVWbwqODt9cJwfB0MVt9awxTghO1UDgZfDcn4JGJ+5SLZpOXo8Y61DR30v/Bbwa57a0NeYP5TVQkua8XY/oxR/IEN9VGOOhTO6siGvg/OJYfhy/vKw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "stefanos@xxxxxxxxxx" <stefanos@xxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>, "Volodymyr_Babchuk@xxxxxxxx" <Volodymyr_Babchuk@xxxxxxxx>, "jbeulich@xxxxxxxx" <jbeulich@xxxxxxxx>, Ayan Kumar Halder <ayankuma@xxxxxxxxxx>, Andre Przywara <Andre.Przywara@xxxxxxx>
- Delivery-date: Wed, 01 Dec 2021 08:40:43 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHX5hXspsh6iwLz8EufEuavNpo0T6wdUegA
- Thread-topic: [PATCH v2] bitops: Fix incorrect value in comment
Hi Ayan,
> On 30 Nov 2021, at 18:12, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxxxxx>
> wrote:
>
> GENMASK(30, 21) should be 0x7fe00000. Fixed this in the comment
> in bitops.h.
>
> Signed-off-by: Ayan Kumar Halder <ayankuma@xxxxxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Cheers
Bertrand
> ---
> Changelog :-
> v2 :- 1. Replaced the word "vector" with "value" in comment.
> 2. Changed 0x07fe00000 to 0x7fe00000.
> 3. Updated the commit message to make it meaningful.
> (All suggested by Jan Beulich)
>
> xen/include/xen/bitops.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/include/xen/bitops.h b/xen/include/xen/bitops.h
> index a64595f68e..dad4b5aa1e 100644
> --- a/xen/include/xen/bitops.h
> +++ b/xen/include/xen/bitops.h
> @@ -5,7 +5,7 @@
> /*
> * Create a contiguous bitmask starting at bit position @l and ending at
> * position @h. For example
> - * GENMASK(30, 21) gives us the 32bit vector 0x01fe00000.
> + * GENMASK(30, 21) gives us the 32bit value 0x7fe00000.
> */
> #define GENMASK(h, l) \
> (((~0UL) << (l)) & (~0UL >> (BITS_PER_LONG - 1 - (h))))
> --
> 2.17.1
>
|
