[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] arm/vgic: Fix reference to a non-existing function


  • To: Michal Orzel <Michal.Orzel@xxxxxxx>
  • From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
  • Date: Fri, 3 Dec 2021 10:19:20 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yg2MfwRaiITANGB5KvOSAQ1TcjDjGwifxAg8X1H07L0=; b=ZT73GQVPC9h4L7JOOs+hmBZFrm8ZRMFTd3KLOn1GBM+Xz4QL7NmM9dsKJvXWn3ljqT378/ERwOD9ggSyw2IiFcG9qt1rDeiSiSxKwVvLmLgr0J6N9faZsD1e94M8g75HpZceLVPIvtJtUDl8adj6raz+QvNKVEQbpa1S74mpjhOSiB0pzqaL+2JmuQZrR42c/QxsuEEWd1eqSHS+hpaCeseGS9VEBpC8jGvUbOmWBOp8oQ53A2dhPBqL+vaYfIE+/Njs9FhWMh0W15W/shQFHMnPJpXBBPvQWlE/GDSFaX7JBMLL1tyf50i0AgAm7uBBimvfEVXvEnCBNCcYm/m+bA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JhET4dgClnO1loAkV+hE1BL/IRRNgVx7vHcnxBGMGq5VCWdgdZeHhtahSk7PAP3EV79iY6WCFvmqaV358m2yQE/CvjJHjGaleEcDq8JlogSZabSKhGZ6tvw8Fe0GBrgSDIudJCx7RMcNUUM7b1iD3BZbfhrExZPOx3y/hzbAhnX2IjP1I+0t0oaMuef8e63GfBLpkeyiCbfLB+dq5W+2ZYgEylNdc6t5bHGtFwewobKczDBqD+XMj5BUkg1cCTssdE2uluSwKQw2GI0D681/d1ovSwoIp/GFjvcdwtDIFPg54sgP3E+tiMBhMWdpPpT53TCwsDix02CiH5N9UNesiQ==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Fri, 03 Dec 2021 10:19:55 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHX6CxjOPaugM9lo0aVspePzsZYTqwgjh6A
  • Thread-topic: [PATCH] arm/vgic: Fix reference to a non-existing function

Hi Michal,

> On 3 Dec 2021, at 09:58, Michal Orzel <Michal.Orzel@xxxxxxx> wrote:
> 
> Commit 68dcdf942326ad90ca527831afbee9cd4a867f84
> (xen/arm: s/gic_set_guest_irq/gic_raise_guest_irq)
> forgot to modify a comment about lr_pending list,
> referring to a function that has been renamed.
> Fix that.
> 
> Fixes: 68dcdf942326ad90ca527831afbee9cd4a867f84
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>

Thanks for that

Cheers
Bertrand

> ---
> xen/include/asm-arm/vgic.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/include/asm-arm/vgic.h b/xen/include/asm-arm/vgic.h
> index e69a59063a..ade427a808 100644
> --- a/xen/include/asm-arm/vgic.h
> +++ b/xen/include/asm-arm/vgic.h
> @@ -195,7 +195,7 @@ struct vgic_cpu {
>      * corresponding LR it is also removed from this list. */
>     struct list_head inflight_irqs;
>     /* lr_pending is used to queue IRQs (struct pending_irq) that the
> -     * vgic tried to inject in the guest (calling gic_set_guest_irq) but
> +     * vgic tried to inject in the guest (calling gic_raise_guest_irq) but
>      * no LRs were available at the time.
>      * As soon as an LR is freed we remove the first IRQ from this
>      * list and write it to the LR register.
> -- 
> 2.29.0
> 




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.